* [Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set
@ 2018-06-20 15:27 Vladimir Sementsov-Ogievskiy
2018-06-20 15:28 ` Vladimir Sementsov-Ogievskiy
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-06-20 15:27 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: eblake, mreitz, armbru, kwolf, den, vsementsov, nshirokovskiy
Libvirt part is ready, let's drop x- prefix.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
qapi/block-core.json | 4 ++--
blockdev.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index cc3ede0630..dfaa050651 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -483,7 +483,7 @@
'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
##
-# @x-block-latency-histogram-set:
+# @block-latency-histogram-set:
#
# Manage read, write and flush latency histograms for the device.
#
@@ -547,7 +547,7 @@
# "arguments": { "device": "drive0" } }
# <- { "return": {} }
##
-{ 'command': 'x-block-latency-histogram-set',
+{ 'command': 'block-latency-histogram-set',
'data': {'device': 'str',
'*boundaries': ['uint64'],
'*boundaries-read': ['uint64'],
diff --git a/blockdev.c b/blockdev.c
index 58d7570932..6d4ae77041 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char *node_name, StrOrNull *iothread,
aio_context_release(old_context);
}
-void qmp_x_block_latency_histogram_set(
+void qmp_block_latency_histogram_set(
const char *device,
bool has_boundaries, uint64List *boundaries,
bool has_boundaries_read, uint64List *boundaries_read,
--
2.11.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set
2018-06-20 15:27 [Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set Vladimir Sementsov-Ogievskiy
@ 2018-06-20 15:28 ` Vladimir Sementsov-Ogievskiy
2018-06-20 16:07 ` [Qemu-devel] [Qemu-block] " John Snow
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-06-20 15:28 UTC (permalink / raw)
To: qemu-devel, qemu-block; +Cc: eblake, mreitz, armbru, kwolf, den, nshirokovskiy
20.06.2018 18:27, Vladimir Sementsov-Ogievskiy wrote:
> Libvirt part is ready, let's drop x- prefix.
libvirt patches will be sent soon I hope.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> qapi/block-core.json | 4 ++--
> blockdev.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index cc3ede0630..dfaa050651 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -483,7 +483,7 @@
> 'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
>
> ##
> -# @x-block-latency-histogram-set:
> +# @block-latency-histogram-set:
> #
> # Manage read, write and flush latency histograms for the device.
> #
> @@ -547,7 +547,7 @@
> # "arguments": { "device": "drive0" } }
> # <- { "return": {} }
> ##
> -{ 'command': 'x-block-latency-histogram-set',
> +{ 'command': 'block-latency-histogram-set',
> 'data': {'device': 'str',
> '*boundaries': ['uint64'],
> '*boundaries-read': ['uint64'],
> diff --git a/blockdev.c b/blockdev.c
> index 58d7570932..6d4ae77041 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char *node_name, StrOrNull *iothread,
> aio_context_release(old_context);
> }
>
> -void qmp_x_block_latency_histogram_set(
> +void qmp_block_latency_histogram_set(
> const char *device,
> bool has_boundaries, uint64List *boundaries,
> bool has_boundaries_read, uint64List *boundaries_read,
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [Qemu-block] [PATCH] qapi: drop x- from x-block-latency-histogram-set
2018-06-20 15:28 ` Vladimir Sementsov-Ogievskiy
@ 2018-06-20 16:07 ` John Snow
0 siblings, 0 replies; 3+ messages in thread
From: John Snow @ 2018-06-20 16:07 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy, qemu-devel, qemu-block
Cc: kwolf, armbru, mreitz, nshirokovskiy, den
On 06/20/2018 11:28 AM, Vladimir Sementsov-Ogievskiy wrote:
> 20.06.2018 18:27, Vladimir Sementsov-Ogievskiy wrote:
>> Libvirt part is ready, let's drop x- prefix.
>
> libvirt patches will be sent soon I hope.
>
OK, can you ping this patch with a link to the series when it is posted?
Thank you,
--js
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> qapi/block-core.json | 4 ++--
>> blockdev.c | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index cc3ede0630..dfaa050651 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -483,7 +483,7 @@
>> 'data': {'boundaries': ['uint64'], 'bins': ['uint64'] } }
>> ##
>> -# @x-block-latency-histogram-set:
>> +# @block-latency-histogram-set:
>> #
>> # Manage read, write and flush latency histograms for the device.
>> #
>> @@ -547,7 +547,7 @@
>> # "arguments": { "device": "drive0" } }
>> # <- { "return": {} }
>> ##
>> -{ 'command': 'x-block-latency-histogram-set',
>> +{ 'command': 'block-latency-histogram-set',
>> 'data': {'device': 'str',
>> '*boundaries': ['uint64'],
>> '*boundaries-read': ['uint64'],
>> diff --git a/blockdev.c b/blockdev.c
>> index 58d7570932..6d4ae77041 100644
>> --- a/blockdev.c
>> +++ b/blockdev.c
>> @@ -4299,7 +4299,7 @@ void qmp_x_blockdev_set_iothread(const char
>> *node_name, StrOrNull *iothread,
>> aio_context_release(old_context);
>> }
>> -void qmp_x_block_latency_histogram_set(
>> +void qmp_block_latency_histogram_set(
>> const char *device,
>> bool has_boundaries, uint64List *boundaries,
>> bool has_boundaries_read, uint64List *boundaries_read,
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-20 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-20 15:27 [Qemu-devel] [PATCH] qapi: drop x- from x-block-latency-histogram-set Vladimir Sementsov-Ogievskiy
2018-06-20 15:28 ` Vladimir Sementsov-Ogievskiy
2018-06-20 16:07 ` [Qemu-devel] [Qemu-block] " John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).