From: Richard Henderson <richard.henderson@linaro.org>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH v2 4/7] target/ppc: introduce avr_full_offset() function
Date: Thu, 7 Mar 2019 10:25:42 -0800 [thread overview]
Message-ID: <f415c038-6a0f-c44b-e2f5-ad2483ae81f5@linaro.org> (raw)
In-Reply-To: <20190307180520.13868-5-mark.cave-ayland@ilande.co.uk>
On 3/7/19 10:05 AM, Mark Cave-Ayland wrote:
> All TCG vector operations require pointers to the base address of the vector
> rather than separate access to the top and bottom 64-bits. Convert the VMX TCG
> instructions to use a new avr_full_offset() function instead of avr64_offset()
> which can then itself be written as a simple wrapper onto vsr_full_offset().
>
> This same function can also reused in cpu_avr_ptr() to avoid having more than
> one copy of the offset calculation logic.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> target/ppc/cpu.h | 12 +++++++++++-
> target/ppc/translate/vmx-impl.inc.c | 22 +++++++++++-----------
> target/ppc/translate/vsx-impl.inc.c | 5 -----
> 3 files changed, 22 insertions(+), 17 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-03-07 18:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 18:05 [Qemu-devel] [PATCH v2 0/7] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order Mark Cave-Ayland
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 1/7] target/ppc: introduce single fpr_offset() function Mark Cave-Ayland
2019-03-07 23:22 ` David Gibson
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 2/7] target/ppc: introduce single vsrl_offset() function Mark Cave-Ayland
2019-03-07 23:23 ` David Gibson
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 3/7] target/ppc: move Vsr* macros from internal.h to cpu.h Mark Cave-Ayland
2019-03-07 18:23 ` Richard Henderson
2019-03-07 21:23 ` Mark Cave-Ayland
2019-03-07 23:27 ` David Gibson
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 4/7] target/ppc: introduce avr_full_offset() function Mark Cave-Ayland
2019-03-07 18:25 ` Richard Henderson [this message]
2019-03-07 23:30 ` David Gibson
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 5/7] target/ppc: improve avr64_offset() and use it to simplify get_avr64()/set_avr64() Mark Cave-Ayland
2019-03-07 18:28 ` Richard Henderson
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 6/7] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order Mark Cave-Ayland
2019-03-07 18:05 ` [Qemu-devel] [PATCH v2 7/7] target/ppc: introduce vsr64_offset() to simplify get_cpu_vsr{l, h}() and set_cpu_vsr{l, h}() Mark Cave-Ayland
2019-03-07 18:30 ` Richard Henderson
2019-03-07 21:00 ` [Qemu-devel] [PATCH v2 0/7] target/ppc: switch fpr/vsrl registers so all VSX registers are in host endian order Richard Henderson
2019-03-07 21:27 ` Mark Cave-Ayland
2019-03-07 23:38 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f415c038-6a0f-c44b-e2f5-ad2483ae81f5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).