From: Robert Hoo <robert.hu@linux.intel.com>
To: Eric Blake <eblake@redhat.com>,
pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
armbru@redhat.com
Cc: robert.hu@intel.com, xiaoyao.li@intel.com, qemu-devel@nongnu.org,
chenyi.qiang@intel.com
Subject: Re: [PATCH 1/2] Introduce (x86) CPU model deprecation API
Date: Fri, 05 Jun 2020 10:47:46 +0800 [thread overview]
Message-ID: <f43f253883e448edbf4cc4e7d685cbf66256f743.camel@linux.intel.com> (raw)
In-Reply-To: <c0c1643d-ff3c-919b-7684-dac14f0d5229@redhat.com>
On Thu, 2020-06-04 at 06:59 -0500, Eric Blake wrote:
> On 6/4/20 3:07 AM, Robert Hoo wrote:
>
> > > > +++ b/qapi/machine-target.json
> > > > @@ -309,7 +309,8 @@
> > > > 'static': 'bool',
> > > > '*unavailable-features': [ 'str' ],
> > > > 'typename': 'str',
> > > > - '*alias-of' : 'str' },
> > > > + '*alias-of' : 'str',
> > > > + 'deprecated' : 'bool' },
> > >
> > > Missing documentation of the new member. Should it be optional
> > > (present
> > > only when true)?
> >
> > Which document do you mean?
Thanks Eric:)
>
> A few lines earlier is '@alias-of: ...'; you'll need to add a
> similar
> line for '@deprecated', mentioning it is '(since 5.1)'.
>
> > How to make it optional?
How about not making it optional? refer to Machineinfo::deprecated.
>
> Name it '*deprecated', then deal with 'has_deprecated' in the C code
> for
> the cases where the member should be output.
>
next prev parent reply other threads:[~2020-06-05 2:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 11:47 [PATCH 1/2] Introduce (x86) CPU model deprecation API Robert Hoo
2020-06-03 11:47 ` [PATCH 2/2] Mark Icelake-Client CPU models deprecated Robert Hoo
2020-06-03 14:11 ` [PATCH 1/2] Introduce (x86) CPU model deprecation API Eric Blake
2020-06-04 8:07 ` Robert Hoo
2020-06-04 11:59 ` Eric Blake
2020-06-05 2:47 ` Robert Hoo [this message]
2020-06-05 13:47 ` Eric Blake
2020-06-06 3:05 ` Robert Hoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43f253883e448edbf4cc4e7d685cbf66256f743.camel@linux.intel.com \
--to=robert.hu@linux.intel.com \
--cc=armbru@redhat.com \
--cc=chenyi.qiang@intel.com \
--cc=eblake@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=robert.hu@intel.com \
--cc=rth@twiddle.net \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).