From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HccFd-0004Fk-U5 for qemu-devel@nongnu.org; Sat, 14 Apr 2007 03:00:49 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HccFc-0004C5-6A for qemu-devel@nongnu.org; Sat, 14 Apr 2007 03:00:49 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HccFc-0004Bu-2K for qemu-devel@nongnu.org; Sat, 14 Apr 2007 03:00:48 -0400 Received: from ug-out-1314.google.com ([66.249.92.171]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HccBD-0002HR-NQ for qemu-devel@nongnu.org; Sat, 14 Apr 2007 02:56:17 -0400 Received: by ug-out-1314.google.com with SMTP id j40so592034ugd for ; Fri, 13 Apr 2007 23:56:09 -0700 (PDT) Message-ID: Date: Sat, 14 Apr 2007 09:56:08 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] FDC and M48T59 save/reset methods In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_17198_23776062.1176533768956" References: <200704132122.17066.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org ------=_Part_17198_23776062.1176533768956 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 4/14/07, Blue Swirl wrote: > On 4/13/07, Paul Brook wrote: > > > I'd like to commit the attached FDC and M48T59 device save and reset > > > methods. After this change, all Sparc32 devices can be saved. > > > > > > Any comments? > > > > Do you also need to save the state of the attached drives? > > Yes, at least motor state, head position and last operation status. > I'll update the patch. Is this version OK? ------=_Part_17198_23776062.1176533768956 Content-Type: text/x-patch; name=common_arch_saves.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f0hpszu5 Content-Disposition: attachment; filename="common_arch_saves.diff" SW5kZXg6IHFlbXUvaHcvZmRjLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2h3L2ZkYy5jCTIw MDctMDQtMTMgMTk6MjI6NTYuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L2h3L2ZkYy5jCTIwMDct MDQtMTQgMDY6NDc6MzAuMDAwMDAwMDAwICswMDAwCkBAIC0xLDcgKzEsNyBAQAogLyoKICAqIFFF TVUgRmxvcHB5IGRpc2sgZW11bGF0b3IgKEludGVsIDgyMDc4KQogICogCi0gKiBDb3B5cmlnaHQg KGMpIDIwMDMgSm9jZWx5biBNYXllcgorICogQ29weXJpZ2h0IChjKSAyMDAzLCAyMDA3IEpvY2Vs eW4gTWF5ZXIKICAqIAogICogUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRlZCwgZnJlZSBvZiBj aGFyZ2UsIHRvIGFueSBwZXJzb24gb2J0YWluaW5nIGEgY29weQogICogb2YgdGhpcyBzb2Z0d2Fy ZSBhbmQgYXNzb2NpYXRlZCBkb2N1bWVudGF0aW9uIGZpbGVzICh0aGUgIlNvZnR3YXJlIiksIHRv IGRlYWwKQEAgLTQ4NSw2ICs0ODUsOTkgQEAKICAgICBmZGN0cmxfd3JpdGVfbWVtLAogfTsKIAor c3RhdGljIHZvaWQgZmRfc2F2ZSAoUUVNVUZpbGUgKmYsIGZkcml2ZV90ICpmZCkKK3sKKyAgICB1 aW50OF90IHRtcDsKKworICAgIHRtcCA9IGZkLT5kcmZsYWdzOworICAgIHFlbXVfcHV0XzhzKGYs ICZ0bXApOworICAgIHFlbXVfcHV0XzhzKGYsICZmZC0+aGVhZCk7CisgICAgcWVtdV9wdXRfOHMo ZiwgJmZkLT50cmFjayk7CisgICAgcWVtdV9wdXRfOHMoZiwgJmZkLT5zZWN0KTsKKyAgICBxZW11 X3B1dF84cyhmLCAmZmQtPmRpcik7CisgICAgcWVtdV9wdXRfOHMoZiwgJmZkLT5ydyk7Cit9CisK K3N0YXRpYyB2b2lkIGZkY19zYXZlIChRRU1VRmlsZSAqZiwgdm9pZCAqb3BhcXVlKQoreworICAg IGZkY3RybF90ICpzID0gb3BhcXVlOworCisgICAgcWVtdV9wdXRfOHMoZiwgJnMtPnN0YXRlKTsK KyAgICBxZW11X3B1dF84cyhmLCAmcy0+ZG1hX2VuKTsKKyAgICBxZW11X3B1dF84cyhmLCAmcy0+ Y3VyX2Rydik7CisgICAgcWVtdV9wdXRfOHMoZiwgJnMtPmJvb3RzZWwpOworICAgIHFlbXVfcHV0 X2J1ZmZlcihmLCBzLT5maWZvLCBGRF9TRUNUT1JfTEVOKTsKKyAgICBxZW11X3B1dF9iZTMycyhm LCAmcy0+ZGF0YV9wb3MpOworICAgIHFlbXVfcHV0X2JlMzJzKGYsICZzLT5kYXRhX2xlbik7Cisg ICAgcWVtdV9wdXRfOHMoZiwgJnMtPmRhdGFfc3RhdGUpOworICAgIHFlbXVfcHV0XzhzKGYsICZz LT5kYXRhX2Rpcik7CisgICAgcWVtdV9wdXRfOHMoZiwgJnMtPmludF9zdGF0dXMpOworICAgIHFl bXVfcHV0XzhzKGYsICZzLT5lb3QpOworICAgIHFlbXVfcHV0XzhzKGYsICZzLT50aW1lcjApOwor ICAgIHFlbXVfcHV0XzhzKGYsICZzLT50aW1lcjEpOworICAgIHFlbXVfcHV0XzhzKGYsICZzLT5w cmVjb21wX3Ryayk7CisgICAgcWVtdV9wdXRfOHMoZiwgJnMtPmNvbmZpZyk7CisgICAgcWVtdV9w dXRfOHMoZiwgJnMtPmxvY2spOworICAgIHFlbXVfcHV0XzhzKGYsICZzLT5wd3JkKTsKKyAgICBm ZF9zYXZlKGYsIHMtPmRyaXZlc1swXSk7CisgICAgZmRfc2F2ZShmLCBzLT5kcml2ZXNbMV0pOwor fQorCitzdGF0aWMgaW50IGZkX2xvYWQgKFFFTVVGaWxlICpmLCBmZHJpdmVfdCAqZmQpCit7Cisg ICAgdWludDhfdCB0bXA7CisKKyAgICBxZW11X2dldF84cyhmLCAmdG1wKTsKKyAgICBmZC0+ZHJm bGFncyA9IHRtcDsKKyAgICBxZW11X2dldF84cyhmLCAmZmQtPmhlYWQpOworICAgIHFlbXVfZ2V0 XzhzKGYsICZmZC0+dHJhY2spOworICAgIHFlbXVfZ2V0XzhzKGYsICZmZC0+c2VjdCk7CisgICAg cWVtdV9nZXRfOHMoZiwgJmZkLT5kaXIpOworICAgIHFlbXVfZ2V0XzhzKGYsICZmZC0+cncpOwor CisgICAgcmV0dXJuIDA7Cit9CisKK3N0YXRpYyBpbnQgZmRjX2xvYWQgKFFFTVVGaWxlICpmLCB2 b2lkICpvcGFxdWUsIGludCB2ZXJzaW9uX2lkKQoreworICAgIGZkY3RybF90ICpzID0gb3BhcXVl OworICAgIGludCByZXQ7CisKKyAgICBpZiAodmVyc2lvbl9pZCAhPSAxKQorICAgICAgICByZXR1 cm4gLUVJTlZBTDsKKworICAgIHFlbXVfZ2V0XzhzKGYsICZzLT5zdGF0ZSk7CisgICAgcWVtdV9n ZXRfOHMoZiwgJnMtPmRtYV9lbik7CisgICAgcWVtdV9nZXRfOHMoZiwgJnMtPmN1cl9kcnYpOwor ICAgIHFlbXVfZ2V0XzhzKGYsICZzLT5ib290c2VsKTsKKyAgICBxZW11X2dldF9idWZmZXIoZiwg cy0+ZmlmbywgRkRfU0VDVE9SX0xFTik7CisgICAgcWVtdV9nZXRfYmUzMnMoZiwgJnMtPmRhdGFf cG9zKTsKKyAgICBxZW11X2dldF9iZTMycyhmLCAmcy0+ZGF0YV9sZW4pOworICAgIHFlbXVfZ2V0 XzhzKGYsICZzLT5kYXRhX3N0YXRlKTsKKyAgICBxZW11X2dldF84cyhmLCAmcy0+ZGF0YV9kaXIp OworICAgIHFlbXVfZ2V0XzhzKGYsICZzLT5pbnRfc3RhdHVzKTsKKyAgICBxZW11X2dldF84cyhm LCAmcy0+ZW90KTsKKyAgICBxZW11X2dldF84cyhmLCAmcy0+dGltZXIwKTsKKyAgICBxZW11X2dl dF84cyhmLCAmcy0+dGltZXIxKTsKKyAgICBxZW11X2dldF84cyhmLCAmcy0+cHJlY29tcF90cmsp OworICAgIHFlbXVfZ2V0XzhzKGYsICZzLT5jb25maWcpOworICAgIHFlbXVfZ2V0XzhzKGYsICZz LT5sb2NrKTsKKyAgICBxZW11X2dldF84cyhmLCAmcy0+cHdyZCk7CisKKyAgICByZXQgPSBmZF9s b2FkKGYsIHMtPmRyaXZlc1swXSk7CisgICAgaWYgKHJldCA9PSAwKQorICAgICAgICByZXQgPSBm ZF9sb2FkKGYsIHMtPmRyaXZlc1sxXSk7CisKKyAgICByZXR1cm4gcmV0OworfQorCitzdGF0aWMg dm9pZCBmZGN0cmxfZXh0ZXJuYWxfcmVzZXQodm9pZCAqb3BhcXVlKQoreworICAgIGZkY3RybF90 ICpzID0gb3BhcXVlOworCisgICAgZmRjdHJsX3Jlc2V0KHMsIDApOworfQorCiBmZGN0cmxfdCAq ZmRjdHJsX2luaXQgKHFlbXVfaXJxIGlycSwgaW50IGRtYV9jaGFubiwgaW50IG1lbV9tYXBwZWQs IAogICAgICAgICAgICAgICAgICAgICAgICB1aW50MzJfdCBpb19iYXNlLAogICAgICAgICAgICAg ICAgICAgICAgICBCbG9ja0RyaXZlclN0YXRlICoqZmRzKQpAQCAtNTI1LDYgKzYxOCw4IEBACiAg ICAgICAgIHJlZ2lzdGVyX2lvcG9ydF93cml0ZShpb19iYXNlICsgMHgwMSwgNSwgMSwgJmZkY3Ry bF93cml0ZSwgZmRjdHJsKTsKICAgICAgICAgcmVnaXN0ZXJfaW9wb3J0X3dyaXRlKGlvX2Jhc2Ug KyAweDA3LCAxLCAxLCAmZmRjdHJsX3dyaXRlLCBmZGN0cmwpOwogICAgIH0KKyAgICByZWdpc3Rl cl9zYXZldm0oImZkYyIsIGlvX2Jhc2UsIDEsIGZkY19zYXZlLCBmZGNfbG9hZCwgZmRjdHJsKTsK KyAgICBxZW11X3JlZ2lzdGVyX3Jlc2V0KGZkY3RybF9leHRlcm5hbF9yZXNldCwgZmRjdHJsKTsK ICAgICBmb3IgKGkgPSAwOyBpIDwgMjsgaSsrKSB7CiAgICAgICAgIGZkX3JldmFsaWRhdGUoJmZk Y3RybC0+ZHJpdmVzW2ldKTsKICAgICB9CkluZGV4OiBxZW11L2h3L200OHQ1OS5jCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHFlbXUub3JpZy9ody9tNDh0NTkuYwkyMDA3LTA0LTEzIDE5OjIyOjU2LjAwMDAwMDAw MCArMDAwMAorKysgcWVtdS9ody9tNDh0NTkuYwkyMDA3LTA0LTE0IDA2OjUxOjAzLjAwMDAwMDAw MCArMDAwMApAQCAtMSw3ICsxLDcgQEAKIC8qCiAgKiBRRU1VIE00OFQ1OSBhbmQgTTQ4VDA4IE5W UkFNIGVtdWxhdGlvbiBmb3IgUFBDIFBSRVAgYW5kIFNwYXJjIHBsYXRmb3JtcwogICogCi0gKiBD b3B5cmlnaHQgKGMpIDIwMDMtMjAwNSBKb2NlbHluIE1heWVyCisgKiBDb3B5cmlnaHQgKGMpIDIw MDMtMjAwNSwgMjAwNyBKb2NlbHluIE1heWVyCiAgKiAKICAqIFBlcm1pc3Npb24gaXMgaGVyZWJ5 IGdyYW50ZWQsIGZyZWUgb2YgY2hhcmdlLCB0byBhbnkgcGVyc29uIG9idGFpbmluZyBhIGNvcHkK ICAqIG9mIHRoaXMgc29mdHdhcmUgYW5kIGFzc29jaWF0ZWQgZG9jdW1lbnRhdGlvbiBmaWxlcyAo dGhlICJTb2Z0d2FyZSIpLCB0byBkZWFsCkBAIC01NzUsMTIgKzU3NSw0NyBAQAogICAgICZudnJh bV9yZWFkbCwKIH07CiAKK3N0YXRpYyB2b2lkIG00OHQ1OV9zYXZlKFFFTVVGaWxlICpmLCB2b2lk ICpvcGFxdWUpCit7CisgICAgbTQ4dDU5X3QgKnMgPSBvcGFxdWU7CisKKyAgICBxZW11X3B1dF84 cyhmLCAmcy0+bG9jayk7CisgICAgcWVtdV9wdXRfYmUxNnMoZiwgJnMtPmFkZHIpOworICAgIHFl bXVfcHV0X2J1ZmZlcihmLCBzLT5idWZmZXIsIHMtPnNpemUpOworfQorCitzdGF0aWMgaW50IG00 OHQ1OV9sb2FkKFFFTVVGaWxlICpmLCB2b2lkICpvcGFxdWUsIGludCB2ZXJzaW9uX2lkKQorewor ICAgIG00OHQ1OV90ICpzID0gb3BhcXVlOworCisgICAgaWYgKHZlcnNpb25faWQgIT0gMSkKKyAg ICAgICAgcmV0dXJuIC1FSU5WQUw7CisKKyAgICBxZW11X2dldF84cyhmLCAmcy0+bG9jayk7Cisg ICAgcWVtdV9nZXRfYmUxNnMoZiwgJnMtPmFkZHIpOworICAgIHFlbXVfZ2V0X2J1ZmZlcihmLCBz LT5idWZmZXIsIHMtPnNpemUpOworCisgICAgcmV0dXJuIDA7Cit9CisKK3N0YXRpYyB2b2lkIG00 OHQ1OV9yZXNldCh2b2lkICpvcGFxdWUpCit7CisgICAgbTQ4dDU5X3QgKk5WUkFNID0gb3BhcXVl OworCisgICAgaWYgKE5WUkFNLT5hbHJtX3RpbWVyICE9IE5VTEwpCisgICAgICAgIHFlbXVfZGVs X3RpbWVyKE5WUkFNLT5hbHJtX3RpbWVyKTsKKworICAgIGlmIChOVlJBTS0+d2RfdGltZXIgIT0g TlVMTCkKKyAgICAgICAgcWVtdV9kZWxfdGltZXIoTlZSQU0tPndkX3RpbWVyKTsKK30KKwogLyog SW5pdGlhbGlzYXRpb24gcm91dGluZSAqLwogbTQ4dDU5X3QgKm00OHQ1OV9pbml0IChxZW11X2ly cSBJUlEsIHRhcmdldF91bG9uZyBtZW1fYmFzZSwKICAgICAgICAgICAgICAgICAgICAgICAgdWlu dDMyX3QgaW9fYmFzZSwgdWludDE2X3Qgc2l6ZSwKICAgICAgICAgICAgICAgICAgICAgICAgaW50 IHR5cGUpCiB7CiAgICAgbTQ4dDU5X3QgKnM7CisgICAgdGFyZ2V0X3Vsb25nIHNhdmVfYmFzZTsK IAogICAgIHMgPSBxZW11X21hbGxvY3ooc2l6ZW9mKG00OHQ1OV90KSk7CiAgICAgaWYgKCFzKQpA QCAtNjEwLDUgKzY0NSw5IEBACiAgICAgfQogICAgIHMtPmxvY2sgPSAwOwogCisgICAgcWVtdV9y ZWdpc3Rlcl9yZXNldChtNDh0NTlfcmVzZXQsIHMpOworICAgIHNhdmVfYmFzZSA9IG1lbV9iYXNl ID8gbWVtX2Jhc2UgOiBpb19iYXNlOworICAgIHJlZ2lzdGVyX3NhdmV2bSgibTQ4dDU5Iiwgc2F2 ZV9iYXNlLCAxLCBtNDh0NTlfc2F2ZSwgbTQ4dDU5X2xvYWQsIHMpOworCiAgICAgcmV0dXJuIHM7 CiB9Cg== ------=_Part_17198_23776062.1176533768956--