From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HpUI0-0005ax-32 for qemu-devel@nongnu.org; Sat, 19 May 2007 15:08:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HpUHy-0005ae-If for qemu-devel@nongnu.org; Sat, 19 May 2007 15:08:27 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HpUHy-0005aV-7M for qemu-devel@nongnu.org; Sat, 19 May 2007 15:08:26 -0400 Received: from ug-out-1314.google.com ([66.249.92.175]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HpUHx-0003rx-JQ for qemu-devel@nongnu.org; Sat, 19 May 2007 15:08:25 -0400 Received: by ug-out-1314.google.com with SMTP id j40so610775ugd for ; Sat, 19 May 2007 12:08:24 -0700 (PDT) Message-ID: Date: Sat, 19 May 2007 22:08:23 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] emulated lance device crashes in debian-sparc32 In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_30393_9331897.1179601703405" References: <20070519071656.74105a87@chirp> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mark@glines.org ------=_Part_30393_9331897.1179601703405 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 5/19/07, Blue Swirl wrote: > On 5/19/07, Mark Glines wrote: > > The weird thing is, when I add "-net nic,model=lance" to my command line > > right before "-net user", the crash does not occur. I kinda assumed from > > the above backtrace that the lance driver was selected on sparc32 by > > default... This patch fixes the crash. But I'm not convinced it's the right one, perhaps the default net parameter logic could be improved instead: /* init network clients */ if (nb_net_clients == 0) { /* if no clients, we use a default config */ pstrcpy(net_clients[0], sizeof(net_clients[0]), "nic"); pstrcpy(net_clients[1], sizeof(net_clients[0]), "user"); nb_net_clients = 2; } Also one of the network options could be a black hole kind of device, such that unlike the "none" type, the device exists, it just can't send or receive anything. ------=_Part_30393_9331897.1179601703405 Content-Type: text/x-diff; name=null_netdevice.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f1wg6vwv Content-Disposition: attachment; filename="null_netdevice.diff" SW5kZXg6IHFlbXUvaHcvc3VuNG0uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBxZW11Lm9yaWcvaHcvc3VuNG0u YwkyMDA3LTA1LTE5IDE4OjM2OjMzLjAwMDAwMDAwMCArMDAwMAorKysgcWVtdS9ody9zdW40bS5j CTIwMDctMDUtMTkgMTg6NDA6MzkuMDAwMDAwMDAwICswMDAwCkBAIC0zMDQsMTUgKzMwNCwxMyBA QAogICAgIH0KICAgICB0Y3hfaW5pdChkcywgaHdkZWYtPnRjeF9iYXNlLCBwaHlzX3JhbV9iYXNl ICsgcmFtX3NpemUsIHJhbV9zaXplLAogICAgICAgICAgICAgIGh3ZGVmLT52cmFtX3NpemUsIGdy YXBoaWNfd2lkdGgsIGdyYXBoaWNfaGVpZ2h0LCBncmFwaGljX2RlcHRoKTsKLSAgICBpZiAobmRf dGFibGVbMF0udmxhbikgewotICAgICAgICBpZiAobmRfdGFibGVbMF0ubW9kZWwgPT0gTlVMTAot ICAgICAgICAgICAgfHwgc3RyY21wKG5kX3RhYmxlWzBdLm1vZGVsLCAibGFuY2UiKSA9PSAwKSB7 Ci0gICAgICAgICAgICBtYWluX2xhbmNlID0gbGFuY2VfaW5pdCgmbmRfdGFibGVbMF0sIGh3ZGVm LT5sZV9iYXNlLCBkbWEsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzbGF2 aW9faXJxW2h3ZGVmLT5sZV9pcnFdKTsKLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIGZw cmludGYoc3RkZXJyLCAicWVtdTogVW5zdXBwb3J0ZWQgTklDOiAlc1xuIiwgbmRfdGFibGVbMF0u bW9kZWwpOwotICAgICAgICAgICAgZXhpdCAoMSk7Ci0gICAgICAgIH0KKyAgICBpZiAobmRfdGFi bGVbMF0ubW9kZWwgPT0gTlVMTAorICAgICAgICB8fCBzdHJjbXAobmRfdGFibGVbMF0ubW9kZWws ICJsYW5jZSIpID09IDApIHsKKyAgICAgICAgbWFpbl9sYW5jZSA9IGxhbmNlX2luaXQoJm5kX3Rh YmxlWzBdLCBod2RlZi0+bGVfYmFzZSwgZG1hLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzbGF2aW9faXJxW2h3ZGVmLT5sZV9pcnFdKTsKKyAgICB9IGVsc2UgeworICAgICAgICBm cHJpbnRmKHN0ZGVyciwgInFlbXU6IFVuc3VwcG9ydGVkIE5JQzogJXNcbiIsIG5kX3RhYmxlWzBd Lm1vZGVsKTsKKyAgICAgICAgZXhpdCAoMSk7CiAgICAgfQogICAgIG52cmFtID0gbTQ4dDU5X2lu aXQoc2xhdmlvX2lycVswXSwgaHdkZWYtPm52cmFtX2Jhc2UsIDAsCiAgICAgICAgICAgICAgICAg ICAgICAgICBod2RlZi0+bnZyYW1fc2l6ZSwgOCk7CkluZGV4OiBxZW11L2h3L3BjbmV0LmMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gcWVtdS5vcmlnL2h3L3BjbmV0LmMJMjAwNy0wNS0xOSAxODozNzo1Ny4wMDAw MDAwMDAgKzAwMDAKKysrIHFlbXUvaHcvcGNuZXQuYwkyMDA3LTA1LTE5IDE4OjUwOjUyLjAwMDAw MDAwMCArMDAwMApAQCAtMTI2Nyw3ICsxMjY3LDggQEAKICAgICAgICAgICAgIGlmIChDU1JfTE9P UChzKSkKICAgICAgICAgICAgICAgICBwY25ldF9yZWNlaXZlKHMsIHMtPmJ1ZmZlciwgcy0+eG1p dF9wb3MpOwogICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIHFlbXVfc2VuZF9wYWNr ZXQocy0+dmMsIHMtPmJ1ZmZlciwgcy0+eG1pdF9wb3MpOworICAgICAgICAgICAgICAgIGlmIChz LT52YykKKyAgICAgICAgICAgICAgICAgICAgcWVtdV9zZW5kX3BhY2tldChzLT52Yywgcy0+YnVm ZmVyLCBzLT54bWl0X3Bvcyk7CiAKICAgICAgICAgICAgIHMtPmNzclswXSAmPSB+MHgwMDA4OyAg IC8qIGNsZWFyIFRETUQgKi8KICAgICAgICAgICAgIHMtPmNzcls0XSB8PSAweDAwMDQ7ICAgIC8q IHNldCBUWFNUUlQgKi8KQEAgLTE1NjIsNyArMTU2Myw4IEBACiAKICAgICAvKiBJbml0aWFsaXpl IHRoZSBQUk9NICovCiAKLSAgICBtZW1jcHkocy0+cHJvbSwgcy0+bmQtPm1hY2FkZHIsIDYpOwor ICAgIGlmIChzLT5uZCkKKyAgICAgICAgbWVtY3B5KHMtPnByb20sIHMtPm5kLT5tYWNhZGRyLCA2 KTsKICAgICBzLT5wcm9tWzEyXSA9IHMtPnByb21bMTNdID0gMHgwMDsKICAgICBzLT5wcm9tWzE0 XSA9IHMtPnByb21bMTVdID0gMHg1NzsKIApAQCAtMTg5OCwxOCArMTkwMCwyMSBAQAogCiAgICAg ZC0+bmQgPSBuZDsKIAotICAgIGQtPnZjID0gcWVtdV9uZXdfdmxhbl9jbGllbnQobmQtPnZsYW4s IHBjbmV0X3JlY2VpdmUsIAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGNuZXRf Y2FuX3JlY2VpdmUsIGQpOwotICAgIAotICAgIHNucHJpbnRmKGQtPnZjLT5pbmZvX3N0ciwgc2l6 ZW9mKGQtPnZjLT5pbmZvX3N0ciksCi0gICAgICAgICAgICAgInBjbmV0IG1hY2FkZHI9JTAyeDol MDJ4OiUwMng6JTAyeDolMDJ4OiUwMngiLAotICAgICAgICAgICAgIGQtPm5kLT5tYWNhZGRyWzBd LAotICAgICAgICAgICAgIGQtPm5kLT5tYWNhZGRyWzFdLAotICAgICAgICAgICAgIGQtPm5kLT5t YWNhZGRyWzJdLAotICAgICAgICAgICAgIGQtPm5kLT5tYWNhZGRyWzNdLAotICAgICAgICAgICAg IGQtPm5kLT5tYWNhZGRyWzRdLAotICAgICAgICAgICAgIGQtPm5kLT5tYWNhZGRyWzVdKTsKLQor ICAgIGlmIChuZCAmJiBuZC0+dmxhbikgeworICAgICAgICBkLT52YyA9IHFlbXVfbmV3X3ZsYW5f Y2xpZW50KG5kLT52bGFuLCBwY25ldF9yZWNlaXZlLAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHBjbmV0X2Nhbl9yZWNlaXZlLCBkKTsKKworICAgICAgICBzbnByaW50Zihk LT52Yy0+aW5mb19zdHIsIHNpemVvZihkLT52Yy0+aW5mb19zdHIpLAorICAgICAgICAgICAgICAg ICAicGNuZXQgbWFjYWRkcj0lMDJ4OiUwMng6JTAyeDolMDJ4OiUwMng6JTAyeCIsCisgICAgICAg ICAgICAgICAgIGQtPm5kLT5tYWNhZGRyWzBdLAorICAgICAgICAgICAgICAgICBkLT5uZC0+bWFj YWRkclsxXSwKKyAgICAgICAgICAgICAgICAgZC0+bmQtPm1hY2FkZHJbMl0sCisgICAgICAgICAg ICAgICAgIGQtPm5kLT5tYWNhZGRyWzNdLAorICAgICAgICAgICAgICAgICBkLT5uZC0+bWFjYWRk cls0XSwKKyAgICAgICAgICAgICAgICAgZC0+bmQtPm1hY2FkZHJbNV0pOworICAgIH0gZWxzZSB7 CisgICAgICAgIGQtPnZjID0gTlVMTDsKKyAgICB9CiAgICAgcGNuZXRfaF9yZXNldChkKTsKICAg ICByZWdpc3Rlcl9zYXZldm0oInBjbmV0IiwgMCwgMiwgcGNuZXRfc2F2ZSwgcGNuZXRfbG9hZCwg ZCk7CiB9Cg== ------=_Part_30393_9331897.1179601703405--