From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HprLe-0004jG-Bt for qemu-devel@nongnu.org; Sun, 20 May 2007 15:45:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HprLb-0004j1-Vl for qemu-devel@nongnu.org; Sun, 20 May 2007 15:45:45 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HprLb-0004iy-Pp for qemu-devel@nongnu.org; Sun, 20 May 2007 15:45:43 -0400 Received: from ug-out-1314.google.com ([66.249.92.171]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HprLb-0001sy-6y for qemu-devel@nongnu.org; Sun, 20 May 2007 15:45:43 -0400 Received: by ug-out-1314.google.com with SMTP id j40so751125ugd for ; Sun, 20 May 2007 12:45:42 -0700 (PDT) Message-ID: Date: Sun, 20 May 2007 22:45:41 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] emulated lance device crashes in debian-sparc32 In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_34005_26228661.1179690341952" References: <20070519071656.74105a87@chirp> <20070520021123.7b01da02@chirp> <200705201125.26929.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Mark Glines , qemu-devel@nongnu.org ------=_Part_34005_26228661.1179690341952 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 5/20/07, Blue Swirl wrote: > On 5/20/07, Paul Brook wrote: > > > > I think Qemu should reject -net user only. Currently that seems to > > > > mean that there is no nic, but still the vlan is connected to slirp > > > > stack. That does not make any sense. > > > > If you do this, do it properly and warn if any qemu vlans have a single device > > attached. > > That is not correct either: -net user,vlan=0 -net socket,connect=1.2.3.4:1234. > > How about this rule: > ((one or more guest devices in a vlan) and (zero with a warning? or > more host devices)) or (no devices at all on either side) This patch implements the logic above. Any comments? ------=_Part_34005_26228661.1179690341952 Content-Type: text/x-diff; name=net_checks.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f1xx5c50 Content-Disposition: attachment; filename="net_checks.diff" SW5kZXg6IHFlbXUvdmwuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBxZW11Lm9yaWcvdmwuYwkyMDA3LTA1LTIw IDE4OjU4OjE0LjAwMDAwMDAwMCArMDAwMAorKysgcWVtdS92bC5jCTIwMDctMDUtMjAgMTk6MzY6 NTMuMDAwMDAwMDAwICswMDAwCkBAIC00MTk1LDYgKzQxOTUsNyBAQAogICAgICAgICB9CiAgICAg ICAgIG5kLT52bGFuID0gdmxhbjsKICAgICAgICAgbmJfbmljcysrOworICAgICAgICB2bGFuLT5u Yl9ndWVzdF9kZXZzKys7CiAgICAgICAgIHJldCA9IDA7CiAgICAgfSBlbHNlCiAgICAgaWYgKCFz dHJjbXAoZGV2aWNlLCAibm9uZSIpKSB7CkBAIC00MjA3LDYgKzQyMDgsNyBAQAogICAgICAgICBp ZiAoZ2V0X3BhcmFtX3ZhbHVlKGJ1Ziwgc2l6ZW9mKGJ1ZiksICJob3N0bmFtZSIsIHApKSB7CiAg ICAgICAgICAgICBwc3RyY3B5KHNsaXJwX2hvc3RuYW1lLCBzaXplb2Yoc2xpcnBfaG9zdG5hbWUp LCBidWYpOwogICAgICAgICB9CisgICAgICAgIHZsYW4tPm5iX2hvc3RfZGV2cysrOwogICAgICAg ICByZXQgPSBuZXRfc2xpcnBfaW5pdCh2bGFuKTsKICAgICB9IGVsc2UKICNlbmRpZgpAQCAtNDIx Nyw2ICs0MjE5LDcgQEAKICAgICAgICAgICAgIGZwcmludGYoc3RkZXJyLCAidGFwOiBubyBpbnRl cmZhY2UgbmFtZVxuIik7CiAgICAgICAgICAgICByZXR1cm4gLTE7CiAgICAgICAgIH0KKyAgICAg ICAgdmxhbi0+bmJfaG9zdF9kZXZzKys7CiAgICAgICAgIHJldCA9IHRhcF93aW4zMl9pbml0KHZs YW4sIGlmbmFtZSk7CiAgICAgfSBlbHNlCiAjZWxzZQpAQCAtNDIzNiw2ICs0MjM5LDcgQEAKICAg ICAgICAgICAgIGlmIChnZXRfcGFyYW1fdmFsdWUoc2V0dXBfc2NyaXB0LCBzaXplb2Yoc2V0dXBf c2NyaXB0KSwgInNjcmlwdCIsIHApID09IDApIHsKICAgICAgICAgICAgICAgICBwc3RyY3B5KHNl dHVwX3NjcmlwdCwgc2l6ZW9mKHNldHVwX3NjcmlwdCksIERFRkFVTFRfTkVUV09SS19TQ1JJUFQp OwogICAgICAgICAgICAgfQorICAgICAgICAgICAgdmxhbi0+bmJfaG9zdF9kZXZzKys7CiAgICAg ICAgICAgICByZXQgPSBuZXRfdGFwX2luaXQodmxhbiwgaWZuYW1lLCBzZXR1cF9zY3JpcHQpOwog ICAgICAgICB9CiAgICAgfSBlbHNlCkBAIC00MjU3LDYgKzQyNjEsNyBAQAogICAgICAgICAgICAg ZnByaW50ZihzdGRlcnIsICJVbmtub3duIHNvY2tldCBvcHRpb25zOiAlc1xuIiwgcCk7CiAgICAg ICAgICAgICByZXR1cm4gLTE7CiAgICAgICAgIH0KKyAgICAgICAgdmxhbi0+bmJfaG9zdF9kZXZz Kys7CiAgICAgfSBlbHNlCiAgICAgewogICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIlVua25vd24g bmV0d29yayBkZXZpY2U6ICVzXG4iLCBkZXZpY2UpOwpAQCAtNjk5Miw2ICs2OTk3LDcgQEAKICAg ICBpbnQgdXNiX2RldmljZXNfaW5kZXg7CiAgICAgaW50IGZkc1syXTsKICAgICBjb25zdCBjaGFy ICpwaWRfZmlsZSA9IE5VTEw7CisgICAgVkxBTlN0YXRlICp2bGFuOwogCiAgICAgTElTVF9JTklU ICgmdm1fY2hhbmdlX3N0YXRlX2hlYWQpOwogI2lmbmRlZiBfV0lOMzIKQEAgLTc2MTEsNiArNzYx NywxOSBAQAogICAgICAgICBpZiAobmV0X2NsaWVudF9pbml0KG5ldF9jbGllbnRzW2ldKSA8IDAp CiAgICAgICAgICAgICBleGl0KDEpOwogICAgIH0KKyAgICBmb3IodmxhbiA9IGZpcnN0X3ZsYW47 IHZsYW4gIT0gTlVMTDsgdmxhbiA9IHZsYW4tPm5leHQpIHsKKyAgICAgICAgaWYgKHZsYW4tPm5i X2d1ZXN0X2RldnMgPT0gMCAmJiB2bGFuLT5uYl9ob3N0X2RldnMgPT0gMCkKKyAgICAgICAgICAg IGNvbnRpbnVlOworICAgICAgICBpZiAodmxhbi0+bmJfZ3Vlc3RfZGV2cyA9PSAwKSB7CisgICAg ICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkludmFsaWQgdmxhbiAoJWQpIHdpdGggbm8gbmljc1xu Iiwgdmxhbi0+aWQpOworICAgICAgICAgICAgZXhpdCgxKTsKKyAgICAgICAgfQorICAgICAgICBp ZiAodmxhbi0+bmJfaG9zdF9kZXZzID09IDApIHsKKyAgICAgICAgICAgIGZwcmludGYoc3RkZXJy LAorICAgICAgICAgICAgICAgICAgICAiV2FybmluZzogdmxhbiAlZCBpcyBub3QgY29ubmVjdGVk IHRvIGhvc3QgbmV0d29ya1xuIiwKKyAgICAgICAgICAgICAgICAgICAgdmxhbi0+aWQpOworICAg ICAgICB9CisgICAgfQogCiAjaWZkZWYgVEFSR0VUX0kzODYKICAgICBpZiAoYm9vdF9kZXZpY2Ug PT0gJ24nKSB7CkluZGV4OiBxZW11L3ZsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL3ZsLmgJ MjAwNy0wNS0yMCAxOTowMTo1OS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvdmwuaAkyMDA3LTA1 LTIwIDE5OjMwOjE2LjAwMDAwMDAwMCArMDAwMApAQCAtMzg5LDYgKzM4OSw3IEBACiAgICAgaW50 IGlkOwogICAgIFZMQU5DbGllbnRTdGF0ZSAqZmlyc3RfY2xpZW50OwogICAgIHN0cnVjdCBWTEFO U3RhdGUgKm5leHQ7CisgICAgaW50IG5iX2d1ZXN0X2RldnMsIG5iX2hvc3RfZGV2czsKIH0gVkxB TlN0YXRlOwogCiBWTEFOU3RhdGUgKnFlbXVfZmluZF92bGFuKGludCBpZCk7Cg== ------=_Part_34005_26228661.1179690341952--