From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ht7Rx-0007fI-4n for qemu-devel@nongnu.org; Tue, 29 May 2007 15:33:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ht7Rt-0007eE-1R for qemu-devel@nongnu.org; Tue, 29 May 2007 15:33:44 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ht7Rs-0007eB-T9 for qemu-devel@nongnu.org; Tue, 29 May 2007 15:33:40 -0400 Received: from an-out-0708.google.com ([209.85.132.251]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ht7Rs-0003Xt-0e for qemu-devel@nongnu.org; Tue, 29 May 2007 15:33:40 -0400 Received: by an-out-0708.google.com with SMTP id d11so756955and for ; Tue, 29 May 2007 12:33:38 -0700 (PDT) Message-ID: Date: Tue, 29 May 2007 22:33:37 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] Regression bug In-Reply-To: <20070529190411.GK4797@volumehost.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_97321_28401719.1180467217178" References: <2765066.1180444125665.JavaMail.root@eastrmwml26.mgt.cox.net> <20070529190411.GK4797@volumehost.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "risc@volumehost.com" Cc: qemu-devel@nongnu.org ------=_Part_97321_28401719.1180467217178 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline On 5/29/07, risc@volumehost.com wrote: > On Tue, May 29, 2007 at 09:44:39PM +0300, Blue Swirl wrote: > > Hi, > > > > I found a bug in the subpage checking code. Could you try if the > > attached patch fixes the problem? > > thats a negative. the exact same behavior as before. Thanks. The bug was actually that on PC, the very last addresses are mapped, and the current code failed when the start_addr + size wrapped back to 0. That didn't happen on amd64, where I first tried to reproduce the bug. The attached patch fixes the problem for me, I'll commit it if there are no objections. ------=_Part_97321_28401719.1180467217178 Content-Type: text/x-diff; name=fix_subpage.diff; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: base64 X-Attachment-Id: f_f2arncl1 Content-Disposition: attachment; filename="fix_subpage.diff" SW5kZXg6IHFlbXUvZXhlYy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9leGVjLmMJMjAwNy0w NS0yOSAxOTozMToxNS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvZXhlYy5jCTIwMDctMDUtMjkg MTk6MzE6MjQuMDAwMDAwMDAwICswMDAwCkBAIC0xOTIyLDcgKzE5MjIsNyBAQAogICAgICAgICAg ICAgICAgIG5lZWRfc3VicGFnZSA9IDE7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgXAogICAgICAgICB9ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgICAgICBpZiAo ZW5kX2FkZHIgLSBhZGRyID4gVEFSR0VUX1BBR0VfU0laRSkgICAgICAgICAgICAgICAgICAgICAg ICAgXAorICAgICAgICBpZiAoKHN0YXJ0X2FkZHIgKyBvcmlnX3NpemUpIC0gYWRkciA+PSBUQVJH RVRfUEFHRV9TSVpFKSAgICAgICAgXAogICAgICAgICAgICAgZW5kX2FkZHIyID0gVEFSR0VUX1BB R0VfU0laRSAtIDE7ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgICAgICBlbHNlIHsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAogICAgICAgICAgICAgZW5kX2FkZHIyID0gKHN0YXJ0X2FkZHIgKyBvcmlnX3NpemUgLSAxKSAm IH5UQVJHRVRfUEFHRV9NQVNLOyBcCkBAIC0xOTQ0LDkgKzE5NDQsOSBAQAogICAgIHVuc2lnbmVk IGxvbmcgb3JpZ19zaXplID0gc2l6ZTsKICAgICB2b2lkICpzdWJwYWdlOwogCi0gICAgZW5kX2Fk ZHIgPSBzdGFydF9hZGRyICsgKHRhcmdldF9waHlzX2FkZHJfdClzaXplOwogICAgIHNpemUgPSAo c2l6ZSArIFRBUkdFVF9QQUdFX1NJWkUgLSAxKSAmIFRBUkdFVF9QQUdFX01BU0s7Ci0gICAgZm9y KGFkZHIgPSBzdGFydF9hZGRyOyBhZGRyIDwgZW5kX2FkZHI7IGFkZHIgKz0gVEFSR0VUX1BBR0Vf U0laRSkgeworICAgIGVuZF9hZGRyID0gc3RhcnRfYWRkciArICh0YXJnZXRfcGh5c19hZGRyX3Qp c2l6ZTsKKyAgICBmb3IoYWRkciA9IHN0YXJ0X2FkZHI7IGFkZHIgIT0gZW5kX2FkZHI7IGFkZHIg Kz0gVEFSR0VUX1BBR0VfU0laRSkgewogICAgICAgICBwID0gcGh5c19wYWdlX2ZpbmQoYWRkciA+ PiBUQVJHRVRfUEFHRV9CSVRTKTsKICAgICAgICAgaWYgKHAgJiYgcC0+cGh5c19vZmZzZXQgIT0g SU9fTUVNX1VOQVNTSUdORUQpIHsKICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgb3JpZ19tZW1v cnkgPSBwLT5waHlzX29mZnNldDsK ------=_Part_97321_28401719.1180467217178--