From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HxR2I-00064x-P4
	for qemu-devel@nongnu.org; Sun, 10 Jun 2007 13:17:06 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HxR2H-000645-4m
	for qemu-devel@nongnu.org; Sun, 10 Jun 2007 13:17:06 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HxR2G-00063w-RH
	for qemu-devel@nongnu.org; Sun, 10 Jun 2007 13:17:04 -0400
Received: from ik-out-1112.google.com ([66.249.90.179])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1HxR2G-00009b-Jo
	for qemu-devel@nongnu.org; Sun, 10 Jun 2007 13:17:04 -0400
Received: by ik-out-1112.google.com with SMTP id c29so1290817ika
	for <qemu-devel@nongnu.org>; Sun, 10 Jun 2007 10:17:03 -0700 (PDT)
Message-ID: <f43fc5580706101017r7f6af56t3b9195be7bcbd72a@mail.gmail.com>
Date: Sun, 10 Jun 2007 20:17:02 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Change variable "name" to avoid shadow
	warnings
In-Reply-To: <466C16C9.9090803@mail.berlios.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <466C16C9.9090803@mail.berlios.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 6/10/07, Stefan Weil <weil@mail.berlios.de> wrote:
> Maybe it would be a good idea to add more warnings to the
> QEMU compiler options. The current option -Wall (in files
> Makefile.target, configure) does not activate all warnings.
>
> I think that especially -Wshadow should be added because code
> with shadowed variables is more difficult to read and maintain
> (and potentially contains more bugs).

I'd vote for -Wcast-align, but I'd be happy with any stricter set of warnings.