From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org, x_at_y_or_z@yahoo.com
Subject: Re: [Qemu-devel] [PATCH] Dump traffic on virtual network to pcap file
Date: Thu, 21 Jun 2007 22:48:22 +0300 [thread overview]
Message-ID: <f43fc5580706211248j4775b92ie54b9afe5d6528d@mail.gmail.com> (raw)
In-Reply-To: <876510.59735.qm@web57005.mail.re3.yahoo.com>
On 6/21/07, Balazs Attila-Mihaly (Cd-MaN) <x_at_y_or_z@yahoo.com> wrote:
> As promised I'll start to provide patches for modifications I've made to the Qemu source code as part of the project. Attached you find the first of these patches - an option to dump the traffic on a virtual interface to a tcpdump compatible file. I welcome any feedback since this is the first time I contributed actual code to an open source project. My main concern is that the code performing the actual dump is bound to the vlan not to the interface (it does the saving in the "qemu_send_packet" procedure). While this is generally speaking ok (since there is usually one vlan per interface per virtual computer), I welcome any suggestion where the code should be put.
To avoid problems in 64-bit hosts, please use uint32_t etc. instead of
int/short. Otherwise the patch looks fine.
prev parent reply other threads:[~2007-06-21 19:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 19:17 [Qemu-devel] [PATCH] Dump traffic on virtual network to pcap file Balazs Attila-Mihaly (Cd-MaN)
2007-06-21 19:48 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580706211248j4775b92ie54b9afe5d6528d@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=x_at_y_or_z@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).