[Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays

[Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays

[Avi Kivity]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Some kvm users complained that the blue and red channels are flipped on 
their displays.  Reverting sdl.c rev 1.40 fixed that problem, so 
apparently that commit made the problem larger than it was previously.

Attached a patch the removes the commit and fixes the problem.  Please 
apply.

-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: sdl-bgr.patch --]
[-- Type: text/x-patch, Size: 552 bytes --]

Index: sdl.c
===================================================================
RCS file: /sources/qemu/qemu/sdl.c,v
retrieving revision 1.44
diff -u -r1.44 sdl.c
--- sdl.c	17 Sep 2007 08:09:45 -0000	1.44
+++ sdl.c	14 Oct 2007 13:49:37 -0000
@@ -87,7 +87,7 @@
     ds->data = screen->pixels;
     ds->linesize = screen->pitch;
     ds->depth = screen->format->BitsPerPixel;
-    if (screen->format->Bshift > screen->format->Rshift) {
+    if (ds->depth == 32 && screen->format->Rshift == 0) {
         ds->bgr = 1;
     } else {
         ds->bgr = 0;

Re: [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays

[Blue Swirl]

On 10/14/07, Avi Kivity <avi@qumranet.com> wrote:
> Some kvm users complained that the blue and red channels are flipped on
> their displays.  Reverting sdl.c rev 1.40 fixed that problem, so
> apparently that commit made the problem larger than it was previously.
>
> Attached a patch the removes the commit and fixes the problem.  Please
> apply.

But this commit was previously reported as the best solution for OSX
(Intel, PPC) and Linux/PPC:
http://article.gmane.org/gmane.comp.emulators.qemu/18071

What kind of machines are the users using?

Re: [kvm-devel] [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays

[Avi Kivity]

Blue Swirl wrote:
> On 10/14/07, Avi Kivity <avi@qumranet.com> wrote:
>   
>> Some kvm users complained that the blue and red channels are flipped on
>> their displays.  Reverting sdl.c rev 1.40 fixed that problem, so
>> apparently that commit made the problem larger than it was previously.
>>
>> Attached a patch the removes the commit and fixes the problem.  Please
>> apply.
>>     
>
> But this commit was previously reported as the best solution for OSX
> (Intel, PPC) and Linux/PPC:
> http://article.gmane.org/gmane.comp.emulators.qemu/18071
>
> What kind of machines are the users using?
>   

No idea, but I got two xdpyinfo logs and both indicated a bgr display.

Perhaps we see here a difference between how SDL behaves on different 
platforms.  Or maybe the test needs to be more subtle.

I haven't had any reports of wrong colors before; of course kvm users 
don't run Linux/PPC os OSX/anything.

-- 
error compiling committee.c: too many arguments to function