From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ih9qu-0003r7-UI for qemu-devel@nongnu.org; Sun, 14 Oct 2007 16:14:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ih9qu-0003qD-DQ for qemu-devel@nongnu.org; Sun, 14 Oct 2007 16:14:20 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ih9qt-0003po-Rl for qemu-devel@nongnu.org; Sun, 14 Oct 2007 16:14:19 -0400 Received: from nf-out-0910.google.com ([64.233.182.191]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ih9qt-0006VC-MI for qemu-devel@nongnu.org; Sun, 14 Oct 2007 16:14:20 -0400 Received: by nf-out-0910.google.com with SMTP id 30so1225777nfu for ; Sun, 14 Oct 2007 13:14:18 -0700 (PDT) Message-ID: Date: Sun, 14 Oct 2007 23:14:13 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] sparc32 use stq_* for 64bit stores In-Reply-To: <4712614B.9050908@earthlink.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_33271_20459535.1192392853750" References: <4712614B.9050908@earthlink.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ------=_Part_33271_20459535.1192392853750 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 10/14/07, Robert Reif wrote: > Use stq_* for 64 bit stores. I changed also uses of 64 bit loads to ldq. But it looks like this makes OpenBIOS trigger alignment traps, this is the same reason why the alignment checks aren't fully enabled. So I can't commit this yet except for the buggy store fix. ------=_Part_33271_20459535.1192392853750 Content-Type: text/x-diff; name="use_ldq.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="use_ldq.diff"; filename="use_ldq.diff" X-Attachment-Id: f_f7rzvmy6 SW5kZXg6IHRhcmdldC1zcGFyYy9vcF9oZWxwZXIuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB0YXJnZXQtc3Bh cmMvb3BfaGVscGVyLmMub3JpZwkyMDA3LTEwLTE0IDE3OjAxOjUyLjAwMDAwMDAwMCArMDAwMAor KysgdGFyZ2V0LXNwYXJjL29wX2hlbHBlci5jCTIwMDctMTAtMTQgMTk6NDg6MjAuMDAwMDAwMDAw ICswMDAwCkBAIC0xNzAsNiArMTcwLDcgQEAKIHZvaWQgaGVscGVyX2xkX2FzaShpbnQgYXNpLCBp bnQgc2l6ZSwgaW50IHNpZ24pCiB7CiAgICAgdWludDMyX3QgcmV0ID0gMDsKKyAgICB1aW50NjRf dCB0bXA7CiAjaWZkZWYgREVCVUdfTVhDQwogICAgIHVpbnQzMl90IGxhc3RfVDAgPSBUMDsKICNl bmRpZgpAQCAtMjQ0LDggKzI0NSw5IEBACiAgICAgICAgICAgICByZXQgPSBsZGxfY29kZShUMCAm IH4zKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDg6Ci0gICAgICAgICAgICBy ZXQgPSBsZGxfY29kZShUMCAmIH4zKTsKLSAgICAgICAgICAgIFQwID0gbGRsX2NvZGUoKFQwICsg NCkgJiB+Myk7CisgICAgICAgICAgICB0bXAgPSBsZHFfY29kZShUMCAmIH43KTsKKyAgICAgICAg ICAgIHJldCA9IHRtcCA+PiAzMjsKKyAgICAgICAgICAgIFQwID0gdG1wICYgMHhmZmZmZmZmZjsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwpAQCAtMjYyLDgg KzI2NCw5IEBACiAgICAgICAgICAgICByZXQgPSBsZGxfdXNlcihUMCAmIH4zKTsKICAgICAgICAg ICAgIGJyZWFrOwogICAgICAgICBjYXNlIDg6Ci0gICAgICAgICAgICByZXQgPSBsZGxfdXNlcihU MCAmIH4zKTsKLSAgICAgICAgICAgIFQwID0gbGRsX3VzZXIoKFQwICsgNCkgJiB+Myk7CisgICAg ICAgICAgICB0bXAgPSBsZHFfdXNlcihUMCAmIH43KTsKKyAgICAgICAgICAgIHJldCA9IHRtcCA+ PiAzMjsKKyAgICAgICAgICAgIFQwID0gdG1wICYgMHhmZmZmZmZmZjsKICAgICAgICAgICAgIGJy ZWFrOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwpAQCAtMjgwLDggKzI4Myw5IEBACiAgICAg ICAgICAgICByZXQgPSBsZGxfa2VybmVsKFQwICYgfjMpOwogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIGNhc2UgODoKLSAgICAgICAgICAgIHJldCA9IGxkbF9rZXJuZWwoVDAgJiB+Myk7Ci0g ICAgICAgICAgICBUMCA9IGxkbF9rZXJuZWwoKFQwICsgNCkgJiB+Myk7CisgICAgICAgICAgICB0 bXAgPSBsZHFfa2VybmVsKFQwICYgfjcpOworICAgICAgICAgICAgcmV0ID0gdG1wID4+IDMyOwor ICAgICAgICAgICAgVDAgPSB0bXAgJiAweGZmZmZmZmZmOwogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KICAgICAgICAgYnJlYWs7CkBAIC0zMDMsOCArMzA3LDkgQEAKICAgICAgICAgICAg IHJldCA9IGxkbF9waHlzKFQwICYgfjMpOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNh c2UgODoKLSAgICAgICAgICAgIHJldCA9IGxkbF9waHlzKFQwICYgfjMpOwotICAgICAgICAgICAg VDAgPSBsZGxfcGh5cygoVDAgKyA0KSAmIH4zKTsKKyAgICAgICAgICAgIHRtcCA9IGxkcV9waHlz KFQwICYgfjcpOworICAgICAgICAgICAgcmV0ID0gdG1wID4+IDMyOworICAgICAgICAgICAgVDAg PSB0bXAgJiAweGZmZmZmZmZmOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAg ICAgYnJlYWs7CkBAIC0zMjUsMTAgKzMzMCwxMCBAQAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAoKHRhcmdldF9waHlzX2FkZHJfdCkoYXNpICYgMHhmKSA8PCAzMikpOwogICAgICAgICAg ICAgYnJlYWs7CiAgICAgICAgIGNhc2UgODoKLSAgICAgICAgICAgIHJldCA9IGxkbF9waHlzKCh0 YXJnZXRfcGh5c19hZGRyX3QpKFQwICYgfjMpCi0gICAgICAgICAgICAgICAgICAgICAgICAgICB8 ICgodGFyZ2V0X3BoeXNfYWRkcl90KShhc2kgJiAweGYpIDw8IDMyKSk7Ci0gICAgICAgICAgICBU MCA9IGxkbF9waHlzKCh0YXJnZXRfcGh5c19hZGRyX3QpKChUMCArIDQpICYgfjMpCisgICAgICAg ICAgICB0bXAgPSBsZHFfcGh5cygodGFyZ2V0X3BoeXNfYWRkcl90KShUMCAmIH43KQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAoKHRhcmdldF9waHlzX2FkZHJfdCkoYXNpICYgMHhmKSA8 PCAzMikpOworICAgICAgICAgICAgcmV0ID0gdG1wID4+IDMyOworICAgICAgICAgICAgVDAgPSB0 bXAgJiAweGZmZmZmZmZmOwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KICAgICAgICAg YnJlYWs7CkBAIC01MTUsOCArNTIwLDcgQEAKICAgICAgICAgICAgIHN0bF91c2VyKFQwICYgfjMs IFQxKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDg6Ci0gICAgICAgICAgICBz dGxfdXNlcihUMCAmIH4zLCBUMSk7Ci0gICAgICAgICAgICBzdGxfdXNlcigoVDAgKyA0KSAmIH4z LCBUMik7CisgICAgICAgICAgICBzdHFfdXNlcihUMCAmIH43LCAoKHVpbnQ2NF90KVQxIDw8IDMy KSB8IFQyKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwpA QCAtNTMzLDggKzUzNyw3IEBACiAgICAgICAgICAgICBzdGxfa2VybmVsKFQwICYgfjMsIFQxKTsK ICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDg6Ci0gICAgICAgICAgICBzdGxfa2Vy bmVsKFQwICYgfjMsIFQxKTsKLSAgICAgICAgICAgIHN0bF9rZXJuZWwoKFQwICsgNCkgJiB+Mywg VDIpOworICAgICAgICAgICAgc3RxX2tlcm5lbChUMCAmIH43LCAoKHVpbnQ2NF90KVQxIDw8IDMy KSB8IFQyKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgICAgIGJyZWFrOwpA QCAtNTkxLDggKzU5NCw3IEBACiAgICAgICAgICAgICAgICAgc3RsX3BoeXMoVDAgJiB+MywgVDEp OwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgY2FzZSA4OgotICAgICAgICAg ICAgICAgIHN0bF9waHlzKFQwICYgfjMsIFQxKTsKLSAgICAgICAgICAgICAgICBzdGxfcGh5cygo VDAgKyA0KSAmIH4zLCBUMik7CisgICAgICAgICAgICAgICAgc3RxX3BoeXMoVDAgJiB+NywgKCh1 aW50NjRfdClUMSA8PCAzMikgfCBUMik7CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAg ICAgICB9CiAgICAgICAgIH0KQEAgLTYxNSwxMCArNjE3LDggQEAKICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgKCh0YXJnZXRfcGh5c19hZGRyX3QpKGFzaSAmIDB4ZikgPDwgMzIpLCBUMSk7 CiAgICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICBjYXNlIDg6Ci0gICAgICAgICAg ICAgICAgc3RsX3BoeXMoKHRhcmdldF9waHlzX2FkZHJfdCkoVDAgJiB+MykKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgIHwgKCh0YXJnZXRfcGh5c19hZGRyX3QpKGFzaSAmIDB4ZikgPDwgMzIp LCBUMSk7Ci0gICAgICAgICAgICAgICAgc3RsX3BoeXMoKHRhcmdldF9waHlzX2FkZHJfdCkoKFQw ICsgNCkgJiB+MykKLSAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgKCh0YXJnZXRfcGh5c19h ZGRyX3QpKGFzaSAmIDB4ZikgPDwgMzIpLCBUMSk7CisgICAgICAgICAgICAgICAgc3RxX3BoeXMo KHRhcmdldF9waHlzX2FkZHJfdCkoVDAgJiB+NykKKyAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgKCh0YXJnZXRfcGh5c19hZGRyX3QpKGFzaSAmIDB4ZikgPDwgMzIpLCAoKHVpbnQ2NF90KVQx IDw8IDMyKSB8IFQyKTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAg ICAgICAgfQpJbmRleDogdGFyZ2V0LXNwYXJjL29wX21lbS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHRhcmdl dC1zcGFyYy9vcF9tZW0uaC5vcmlnCTIwMDctMTAtMTQgMTk6NDE6MDEuMDAwMDAwMDAwICswMDAw CisrKyB0YXJnZXQtc3BhcmMvb3BfbWVtLmgJMjAwNy0xMC0xNCAxOTo1NTowMi4wMDAwMDAwMDAg KzAwMDAKQEAgLTM2LDggKzM2LDcgQEAKIAogdm9pZCBPUFBST1RPIGdsdWUob3Bfc3RkLCBNRU1T VUZGSVgpKHZvaWQpCiB7Ci0gICAgZ2x1ZShzdGwsIE1FTVNVRkZJWCkoQUREUihUMCksIFQxKTsK LSAgICBnbHVlKHN0bCwgTUVNU1VGRklYKSgoQUREUihUMCArIDQpKSwgVDIpOworICAgIGdsdWUo c3RxLCBNRU1TVUZGSVgpKEFERFIoVDApLCAoVDEgPDwgMzIpIHwgKFQyICYgMHhmZmZmZmZmZikp OwogfQogCiB2b2lkIE9QUFJPVE8gZ2x1ZShvcF9sZHN0dWIsIE1FTVNVRkZJWCkodm9pZCkKQEAg LTU1LDggKzU0LDExIEBACiAKIHZvaWQgT1BQUk9UTyBnbHVlKG9wX2xkZCwgTUVNU1VGRklYKSh2 b2lkKQogewotICAgIFQxID0gZ2x1ZShsZGwsIE1FTVNVRkZJWCkoQUREUihUMCkpOwotICAgIFQw ID0gZ2x1ZShsZGwsIE1FTVNVRkZJWCkoKEFERFIoVDAgKyA0KSkpOworICAgIHRhcmdldF91bG9u ZyB0bXA7CisKKyAgICB0bXAgPSBnbHVlKGxkcSwgTUVNU1VGRklYKShBRERSKFQwKSk7CisgICAg VDEgPSB0bXAgPj4gMzI7CisgICAgVDAgPSB0bXAgJiAweGZmZmZmZmZmOwogfQogCiAvKioqICAg ICAgICAgICAgICAgICAgICAgICAgIEZsb2F0aW5nLXBvaW50IHN0b3JlICAgICAgICAgICAgICAg ICAgICAgICAgICAqKiovCg== ------=_Part_33271_20459535.1192392853750--