[Qemu-devel] [PATCH] Fix compilation bug in slirp code

[Qemu-devel] [PATCH] Fix compilation bug in slirp code

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

Hi,

tcpemu is a global variable (declared in slirp/misc.h).
A later "static" declaration raises a compilation error
with newer gcc versions. The patch fixes the declaration
in slirp/tcp_subr.c.

Regards
Stefan


[-- Attachment #2: tcp_subr.patch --]
[-- Type: text/x-diff, Size: 441 bytes --]

Index: slirp/tcp_subr.c
===================================================================
RCS file: /sources/qemu/qemu/slirp/tcp_subr.c,v
retrieving revision 1.12
diff -u -r1.12 tcp_subr.c
--- slirp/tcp_subr.c	26 Oct 2007 19:34:46 -0000	1.12
+++ slirp/tcp_subr.c	1 Nov 2007 10:22:57 -0000
@@ -559,7 +559,7 @@
 	  {0, 0, 0, 0}
 };
 
-static struct emu_t *tcpemu = 0;
+struct emu_t *tcpemu;
 
 /*
  * Return TOS according to the above table

Re: [Qemu-devel] [PATCH] Fix compilation bug in slirp code

[Blue Swirl]

On 11/1/07, Stefan Weil <weil@mail.berlios.de> wrote:
> Hi,
>
> tcpemu is a global variable (declared in slirp/misc.h).
> A later "static" declaration raises a compilation error
> with newer gcc versions. The patch fixes the declaration
> in slirp/tcp_subr.c.

The only user outside tcp_subr.c in misc.c is disabled with #ifdef
CONFIG_QEMU, so I'll fix this by disabling the global definition in
misc.h and 'static' keyword in tcp_subr.c with the same #ifdef.

Thanks anyways.