From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1InfZw-0000SJ-L7 for qemu-devel@nongnu.org; Thu, 01 Nov 2007 15:19:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1InfZs-0000Qp-1D for qemu-devel@nongnu.org; Thu, 01 Nov 2007 15:19:43 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1InfZr-0000Qm-Pu for qemu-devel@nongnu.org; Thu, 01 Nov 2007 15:19:39 -0400 Received: from nf-out-0910.google.com ([64.233.182.185]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1InfZr-0005lI-A0 for qemu-devel@nongnu.org; Thu, 01 Nov 2007 15:19:39 -0400 Received: by nf-out-0910.google.com with SMTP id 30so543011nfu for ; Thu, 01 Nov 2007 12:19:36 -0700 (PDT) Message-ID: Date: Thu, 1 Nov 2007 21:19:35 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] Fix compilation bug in slirp code In-Reply-To: <4729F593.9030909@mail.berlios.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4729F593.9030909@mail.berlios.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 11/1/07, Stefan Weil wrote: > Hi, > > tcpemu is a global variable (declared in slirp/misc.h). > A later "static" declaration raises a compilation error > with newer gcc versions. The patch fixes the declaration > in slirp/tcp_subr.c. The only user outside tcp_subr.c in misc.c is disabled with #ifdef CONFIG_QEMU, so I'll fix this by disabling the global definition in misc.h and 'static' keyword in tcp_subr.c with the same #ifdef. Thanks anyways.