From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Irc4i-0003t2-UH
	for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:23:48 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Irc4h-0003sO-AF
	for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:23:48 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Irc4h-0003sL-4f
	for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:23:47 -0500
Received: from ug-out-1314.google.com ([66.249.92.168])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Irc4g-0006TO-JV
	for qemu-devel@nongnu.org; Mon, 12 Nov 2007 11:23:46 -0500
Received: by ug-out-1314.google.com with SMTP id m2so736576uge
	for <qemu-devel@nongnu.org>; Mon, 12 Nov 2007 08:23:45 -0800 (PST)
Message-ID: <f43fc5580711120823h5735c445yef5da7dc325da7c@mail.gmail.com>
Date: Mon, 12 Nov 2007 18:23:43 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/2][UPDATE] remove unused parameters from
	QEMUMachineInitFunc
In-Reply-To: <1194879921937@bull.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1194879921645@bull.net> <1194879921937@bull.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org

On 11/12/07, Laurent Vivier <Laurent.Vivier@bull.net> wrote:
>
> It appears that fd_filename and snapshot are not needed/used by machine
> init functions (QEMUMachineInitFunc).
>
> This patch removes them.

I don't know what was the idea for these parameters, so I can't
comment on the correctness of the patch in general.

>  /* SPARCstation 5 hardware initialisation */
> -static void ss5_init(int RAM_size, int vga_ram_size, const char *boot_device,
> -                       DisplayState *ds, const char **fd_filename, int snapshot,
> +static void ss5_init(int RAM_size, int vga_ram_size,
> +                       const char *boot_device, DisplayState *ds,
>                         const char *kernel_filename, const char *kernel_cmdline,
>                         const char *initrd_filename, const char *cpu_model)
>  {
> @@ -616,8 +616,8 @@ static void ss5_init(int RAM_size, int v
>  }
>
>  /* SPARCstation 10 hardware initialisation */
> -static void ss10_init(int RAM_size, int vga_ram_size, const char *boot_device,
> -                            DisplayState *ds, const char **fd_filename, int snapshot,
> +static void ss10_init(int RAM_size, int vga_ram_size,
> +                            const char *boot_device, DisplayState *ds,
>                              const char *kernel_filename, const char *kernel_cmdline,
>                              const char *initrd_filename, const char *cpu_model)

You didn't fix ss600mp_init, which was added yesterday.