qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2][UPDATE] Add arg -drive to define new drive with more features
Date: Tue, 13 Nov 2007 22:50:55 +0200	[thread overview]
Message-ID: <f43fc5580711131250k6bbfb00akb427c5dfa76fabb@mail.gmail.com> (raw)
In-Reply-To: <1194969743.3673.11.camel@frecb07144>

On 11/13/07, Laurent Vivier <Laurent.Vivier@bull.net> wrote:
> Attached is an updated patch (corrected as you want and with more check
> on -drive arguments)

Sparc64 didn't compile until I added a MAX_IDE_BUS #define.

SS-600MP case is still missing from vl.c and the -drive help text is
longer than 80 chars.

I'd prefer a space after 'for' and 'if', though these styles aren't
very consistently used in the original files.

Good news is that after adding the #define, patched Qemu seems to
work. I tested briefly both Sparc32 and Sparc64.

  reply	other threads:[~2007-11-13 20:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 15:05 [Qemu-devel] [PATCH 0/2][UPDATE] Add "-drive" parameter Laurent Vivier
2007-11-12 15:05 ` [Qemu-devel] [PATCH 1/2][UPDATE] remove unused parameters from QEMUMachineInitFunc Laurent Vivier
2007-11-12 15:05   ` [Qemu-devel] [PATCH 2/2][UPDATE] Add arg -drive to define new drive with more features Laurent Vivier
2007-11-12 16:44     ` Blue Swirl
2007-11-12 16:53       ` Laurent Vivier
2007-11-13 16:02       ` Laurent Vivier
2007-11-13 20:50         ` Blue Swirl [this message]
2007-11-13 21:22           ` Laurent Vivier
2007-11-12 16:23   ` [Qemu-devel] [PATCH 1/2][UPDATE] remove unused parameters from QEMUMachineInitFunc Blue Swirl
2007-11-12 16:36     ` Laurent Vivier
2007-11-12 17:14       ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580711131250k6bbfb00akb427c5dfa76fabb@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).