From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Is2ip-0006x0-S4
	for qemu-devel@nongnu.org; Tue, 13 Nov 2007 15:50:59 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Is2io-0006wo-O4
	for qemu-devel@nongnu.org; Tue, 13 Nov 2007 15:50:59 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Is2io-0006wk-K1
	for qemu-devel@nongnu.org; Tue, 13 Nov 2007 15:50:58 -0500
Received: from nf-out-0910.google.com ([64.233.182.191])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Is2io-0004IY-2t
	for qemu-devel@nongnu.org; Tue, 13 Nov 2007 15:50:58 -0500
Received: by nf-out-0910.google.com with SMTP id 30so1539648nfu
	for <qemu-devel@nongnu.org>; Tue, 13 Nov 2007 12:50:55 -0800 (PST)
Message-ID: <f43fc5580711131250k6bbfb00akb427c5dfa76fabb@mail.gmail.com>
Date: Tue, 13 Nov 2007 22:50:55 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2][UPDATE] Add arg -drive to define new
	drive with more features
In-Reply-To: <1194969743.3673.11.camel@frecb07144>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1194879921937@bull.net> <11948799213737@bull.net>
	<f43fc5580711120844t6b574c08j847a99e0193598be@mail.gmail.com>
	<1194969743.3673.11.camel@frecb07144>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 11/13/07, Laurent Vivier <Laurent.Vivier@bull.net> wrote:
> Attached is an updated patch (corrected as you want and with more check
> on -drive arguments)

Sparc64 didn't compile until I added a MAX_IDE_BUS #define.

SS-600MP case is still missing from vl.c and the -drive help text is
longer than 80 chars.

I'd prefer a space after 'for' and 'if', though these styles aren't
very consistently used in the original files.

Good news is that after adding the #define, patched Qemu seems to
work. I tested briefly both Sparc32 and Sparc64.