From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IskSb-0006ZI-1j for qemu-devel@nongnu.org; Thu, 15 Nov 2007 14:33:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IskSY-0006Ur-6Q for qemu-devel@nongnu.org; Thu, 15 Nov 2007 14:33:08 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IskSX-0006Ud-U5 for qemu-devel@nongnu.org; Thu, 15 Nov 2007 14:33:05 -0500 Received: from ug-out-1314.google.com ([66.249.92.170]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IskSX-0003Wg-LR for qemu-devel@nongnu.org; Thu, 15 Nov 2007 14:33:05 -0500 Received: by ug-out-1314.google.com with SMTP id m2so508384uge for ; Thu, 15 Nov 2007 11:33:04 -0800 (PST) Message-ID: Date: Thu, 15 Nov 2007 21:33:04 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] sparc32 asi cleanups and debug printf In-Reply-To: <47362227.20805@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4735F83F.6020607@earthlink.net> <47362227.20805@earthlink.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 11/10/07, Robert Reif wrote: > Blue Swirl wrote: > > >DPRINTF_ASI would be nice. > > > > > > > Here is a revised patch: Thanks. The patch didn't apply completely. I noticed that there are some too long lines, they should be wrapped. Module reset register should be in a different patch. Cache ASIs are implemented, they just do nothing, so the debug text should only apply to the store buffer (but not Ross I-cache flush?) and breakpoint ASIs. This by the way highlights that there should be a mechanism to register CPU specific ASIs and their handlers so that these ASI conflicts can be resolved. Because on Sparc32 we know the ASI at translation time, the handler can be selected then to get a small speedup.