From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ItJjS-0004mc-Me for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:12:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ItJjR-0004kd-AE for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:12:53 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ItJjR-0004kS-0G for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:12:53 -0500 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1ItJjQ-0000ZE-D2 for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:12:52 -0500 Received: from nf-out-0910.google.com ([64.233.182.188]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ItJjP-0004OE-QL for qemu-devel@nongnu.org; Sat, 17 Nov 2007 04:12:51 -0500 Received: by nf-out-0910.google.com with SMTP id 30so1090500nfu for ; Sat, 17 Nov 2007 01:12:49 -0800 (PST) Message-ID: Date: Sat, 17 Nov 2007 11:12:49 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] add iommu version to sparc32 In-Reply-To: <473CCE9A.1010709@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <4738DB62.3080008@earthlink.net> <473CCE9A.1010709@earthlink.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 11/16/07, Robert Reif wrote: > > >>Add iommu version to sparc32. Also reset iommu after initialization. > >> > >> > > > >Should the version be tied to CPU model instead of machine type? At > >least for Turbosparc this seems to be the case. > > > > > On SMP systems the IOMMU is on the system board in a separate ASIC. On > single CPU systems the IOMMU is integrated into the CPU. Without checking > the FEH, the SS 5 was the only single CPU system that shipped with more than > one family of CPUs (MicroSparc II and TurboSparc and they do have different > IOMMU versions). That could be special cased. OK, then the machine is more correct place. Thanks, patch applied. > Unfortunately QEMU will allow you to specify unrealistic systems. We > should > probably add allowable CPU types to specific machine types to catch this. Well, there are plenty of things that can be unrealistic, for example memory size. For the IOMMU case, Linux does not make any checks for the version, same with NetBSD. I don't think it matters too much.