* [Qemu-devel] [PATCH] sparc32 fix MXCC error bit clearing
@ 2007-11-15 23:30 Robert Reif
2007-11-17 9:22 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Robert Reif @ 2007-11-15 23:30 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 38 bytes --]
Fix MXCC error register bit clearing.
[-- Attachment #2: reset1.diff.txt --]
[-- Type: text/plain, Size: 1079 bytes --]
Index: target-sparc/op_helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-sparc/op_helper.c,v
retrieving revision 1.52
diff -p -u -r1.52 op_helper.c
--- target-sparc/op_helper.c 11 Nov 2007 19:46:09 -0000 1.52
+++ target-sparc/op_helper.c 15 Nov 2007 23:28:12 -0000
@@ -438,13 +446,11 @@ void helper_st_asi(int asi, int size)
DPRINTF_MXCC("%08x: unimplemented access size: %d\n", T0, size);
break;
case 0x01c00e00: /* MXCC error register */
+ // writing a 1 bit clears the error
if (size == 8)
- env->mxccregs[6] = ((uint64_t)T1 << 32) | T2;
+ env->mxccregs[6] &= ~(((uint64_t)T1 << 32) | T2);
else
DPRINTF_MXCC("%08x: unimplemented access size: %d\n", T0, size);
- if (env->mxccregs[6] == 0xffffffffffffffffULL) {
- // this is probably a reset
- }
break;
case 0x01c00f00: /* MBus port address register */
if (size == 8)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] sparc32 fix MXCC error bit clearing
2007-11-15 23:30 [Qemu-devel] [PATCH] sparc32 fix MXCC error bit clearing Robert Reif
@ 2007-11-17 9:22 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2007-11-17 9:22 UTC (permalink / raw)
To: qemu-devel
On 11/16/07, Robert Reif <reif@earthlink.net> wrote:
> Fix MXCC error register bit clearing.
Thanks, applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-17 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-15 23:30 [Qemu-devel] [PATCH] sparc32 fix MXCC error bit clearing Robert Reif
2007-11-17 9:22 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).