From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IuC6u-00022B-LG
	for qemu-devel@nongnu.org; Mon, 19 Nov 2007 14:16:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IuC6t-00021u-3T
	for qemu-devel@nongnu.org; Mon, 19 Nov 2007 14:16:44 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IuC6t-00021r-0f
	for qemu-devel@nongnu.org; Mon, 19 Nov 2007 14:16:43 -0500
Received: from ug-out-1314.google.com ([66.249.92.174])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1IuC6s-0000DA-Ob
	for qemu-devel@nongnu.org; Mon, 19 Nov 2007 14:16:42 -0500
Received: by ug-out-1314.google.com with SMTP id m2so972463uge
	for <qemu-devel@nongnu.org>; Mon, 19 Nov 2007 11:16:41 -0800 (PST)
Message-ID: <f43fc5580711191116p3a29dc74s302e5a15b839264a@mail.gmail.com>
Date: Mon, 19 Nov 2007 21:16:41 +0200
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [RFC][PATCH] fix sparc32 mxcc 64 bit read word order
In-Reply-To: <4740A735.8060508@earthlink.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <473C4027.3030608@earthlink.net>
	<f43fc5580711151010x3c1ca9e8secd48a2d060418ae@mail.gmail.com>
	<473CD151.6050000@earthlink.net>
	<f43fc5580711170121m141efb3dr5622b3ba09fa6dfc@mail.gmail.com>
	<4740A735.8060508@earthlink.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 11/18/07, Robert Reif <reif@earthlink.net> wrote:
> Blue Swirl wrote:
>
> >On 11/16/07, Robert Reif <reif@earthlink.net> wrote:
> >
> >
> >>>This patch fixes the word order for 64 bit reads of the mxcc registers.
> >>>
> >>>
> >
> >Otherwise everything seems OK, but it breaks NetBSD version 3 on SS10:
> >clock0 at obio0 slot 0 offset 0x200000: mk48t08
> >timer0 at obio0 slot 0 offset 0x300000data fault: pc=0xf0111a0c
> >addr=0x0 sfsr=126<PERR=0,LVL=1,AT=1,FT=1,FAV,OW>
> >panic: kernel fault
> >halted
> >
> >halt, power off
> >
> >Without the patch I get:
> >clock0 at obio0 slot 0 offset 0x200000: mk48t08
> >timer0 at obio0 slot 0 offset 0x300000: delay constant 99
> >zs0 at obio0 slot 0 offset 0x100000 level 12 softpri 6
> >zstty0 at zs0 channel 0 (console i/o)
> >zstty1 at zs0 channel 1
> >scsi-disk: Unsupported command length, command 79
> >
> >
> >
> >
> >
> This is a classic case of two wrongs make a right.  OpenBios need to be
> fixed to set mbus module id to start at 8, not 0 for mbus based machines.
>
>
>
> Index: drivers/obio.c
> ===================================================================
> --- drivers/obio.c      (revision 178)
> +++ drivers/obio.c      (working copy)
> @@ -891,7 +891,15 @@
>          push_str("cache-coherence?");
>          fword("property");
>
> -        PUSH(i);
> +       switch (machine_id) {
> +        case 0x71:
> +        case 0x72:
> +            PUSH(i + 8);
> +            break;
> +        case 0x80:
> +            PUSH(i);
> +            break;
> +        }
>          fword("encode-int");
>          push_str("mid");
>          fword("property");
>
>

Thanks, both patches applied.