Re: [Qemu-devel] [PATCH][UPDATE3] Add -drive parameter

["Blue Swirl" <blauwirbel@gmail.com>]

On 11/19/07, Laurent Vivier <Laurent.Vivier@bull.net> wrote:
>
> This is an update with Qemu CVS tree and comments from Blue Swirl.
>
> This patch introduces a new parameter allowing to define drives.
>
> The new parameter is "-drive":
>
>     -drive [file=file][,if=type][,bus=n][,unit=m][,media=d][index=i][,cyls=c,heads=h,secs=s[,trans=t]][snapshot=on|off]
>
> where:
>
>     file is the disk image
>     type is the interface type (ide, scsi, sd, mtd, floppy, pflash)
>     n is the bus number of the given type
>     m is the unit number on the given bus
>     d is the type of the media (disk, cdrom)
>     c,h,s,t are the parameters usually given by -hdachs
>     snapshot allows to enable or not the snapshot for this disk
>     i is an index number within the given type (replace bus,unit)
>
> "-cdrom file" is an alias for "-drive file=file,index=2,media=cdrom"
> "-hda file" is an alias for "-drive file=file,index=0,media=disk"
> "-hdb file" is an alias for "-drive file=file,index=1,media=disk"
> "-hdc file" is an alias for "-drive file=file,index=2,media=disk"
> "-hdd file" is an alias for "-drive file=file,index=3,media=disk"
> "-hda file -hdachs a,b,c" is an alias for
>                  "-drive file=file,index=0,cyls=a,heads=b,secs=c"
>
> You can also define a cdrom on the slace of ide0 with:
> "-drive file=file,if=ide,index=1,media=cdrom"
>
> You can define an empty cdrom:
> "-drive if=ide,index=1,media=cdrom"
>
> "-drive file=file,if=scsi,bus=0,unit=6" allows to connect the disk image file
> to the scsi bus 0 with the unit id 6.
>
> if there is no SCSI disk, the SCSI interface is not created.
>
> It also defines the default interface type to "scsi" for targets
> "realview", "SS-5", "SS-10", "versatilepb", "versatileab"
> to keep old behavior, where "-hda" is a SCSI disk.
>
> "-fda file" is an alias for "-drive file=file,index=0,if=floppy"
> "-fdb file" is an alias for "-drive file=file,index=1,if=floppy"
> "-pflash file" is an alias for "-drive file=file,if=pflash"
> "-mtdblock file" is an alias for "-drive file=file,if=mtd"
> "-sd file" becomes the alias of "-drive file=file,if=sd"
>
> "-drive file=a -drive file=b" will be interpreted like "-hda a -hdb b"

Any objections to committing this patch? To me it looks fine, but I
have tested only Sparc.