[Qemu-devel] some patches for qemu for pkgsrc, DragonFly, NetBSD, HOST_PPC, without POSIX AIO, and more

[Qemu-devel] some patches for qemu for pkgsrc, DragonFly, NetBSD, HOST_PPC, without POSIX AIO, and more

[Jeremy C. Reed]

The pkgsrc build system has several patches against qemu 0.9.0.

They are at:

http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/emulators/qemu/patches/

Do you want them submitted in a certain way?

Re: [Qemu-devel] some patches for qemu for pkgsrc, DragonFly, NetBSD, HOST_PPC, without POSIX AIO, and more

[Jeremy C. Reed]

On Fri, 30 Nov 2007, Jeremy C. Reed wrote:

> The pkgsrc build system has several patches against qemu 0.9.0.
> 
> They are at:
> 
> http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/emulators/qemu/patches/
> 
> Do you want them submitted in a certain way?

I forgot to mention that patch-ag above is wrong as it assumes "uname -p" 
works everywhere. Here is my change for that:

--- configure.orig      2007-02-05 17:01:54.000000000 -0600
+++ configure   2007-11-30 09:47:01.000000000 -0600
@@ -29,7 +29,10 @@
 make="make"
 install="install"
 strip="strip"
-cpu=`uname -m`
+cpu=`uname -p`
+if [ "$cpu" = "unknown" ]; then
+  cpu=`uname -m`
+fi
 target_list=""
 case "$cpu" in
   i386|i486|i586|i686|i86pc|BePC)


(Please still see patch-ag as it has changes for powerpc, dragonfly, and 
HAVE_MACHINE_BSWAP_H. Ignore the mandir part.)

Re: [Qemu-devel] some patches for qemu for pkgsrc, DragonFly, NetBSD, HOST_PPC, without POSIX AIO, and more

[Blue Swirl]

On 11/30/07, Jeremy C. Reed <reed@reedmedia.net> wrote:
> On Fri, 30 Nov 2007, Jeremy C. Reed wrote:
>
> > The pkgsrc build system has several patches against qemu 0.9.0.
> >
> > They are at:
> >
> > http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/emulators/qemu/patches/
> >
> > Do you want them submitted in a certain way?

Unified diff from top level, unrelated changes preferably in separate patches?

patch-aa: HAVE_MACHINE_BSWAP_H excludes HAVE_BYTESWAP_H, why?
patch-ac: the affected code is conditional on __linux__, why does this
have to be changed for NetBSD? Is __APPLE__ equal to _BSD for all
Apples?
patch-ag: BSD_INSTALL_ stuff isn't defined anywhere?
patch-am: OK, I think
patch-ao: Ugly, is it really possible for some system define to
corrupt a variable that happens to be similar? Or what is the problem?
patch-au: OK
patch-av: maybe better place would be cutils.c or host-utils.c
patch-aw: don't know much about PPC host, but looks strange
patch-ax: if a helper is needed, please put it into op_helper.c, see
for example Sparc op.c for use of USE_INT_TO_FLOAT_HELPERS
patch-ay: looks OK

By the way, maybe someone who knows NetBSD kernel internals could find
out why NetBSD/Sparc can't boot on Qemu. It would be nice to get other
OSes beside Linux run.

Re: [Qemu-devel] some patches for qemu for pkgsrc, DragonFly, NetBSD, HOST_PPC, without POSIX AIO, and more

[Paul Brook]

On Friday 30 November 2007, Blue Swirl wrote:
> On 11/30/07, Jeremy C. Reed <reed@reedmedia.net> wrote:
> > On Fri, 30 Nov 2007, Jeremy C. Reed wrote:
> > > The pkgsrc build system has several patches against qemu 0.9.0.
> > >
> > > They are at:
> > >
> > > http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/emulators/qemu/patches/
> > >
> > > Do you want them submitted in a certain way?
>
> Unified diff from top level, unrelated changes preferably in separate
> patches?

And with a proper description of exactly what it's fixing and why it should be 
fixed that way.

Paul