From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J1Pl2-0005Od-NW for qemu-devel@nongnu.org; Sun, 09 Dec 2007 12:16:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J1Pl0-0005O2-ON for qemu-devel@nongnu.org; Sun, 09 Dec 2007 12:15:59 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J1Pl0-0005Nz-Ij for qemu-devel@nongnu.org; Sun, 09 Dec 2007 12:15:58 -0500 Received: from rn-out-0910.google.com ([64.233.170.190] helo=rn-out-0102.google.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J1Pl0-0006Rm-Aa for qemu-devel@nongnu.org; Sun, 09 Dec 2007 12:15:58 -0500 Received: by rn-out-0102.google.com with SMTP id i19so232688rng for ; Sun, 09 Dec 2007 09:15:57 -0800 (PST) Message-ID: Date: Sun, 9 Dec 2007 19:15:56 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH] sparc32 sun4m eccmemctl In-Reply-To: <475BFD16.5010101@earthlink.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <475BFD16.5010101@earthlink.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On 12/9/07, Robert Reif wrote: > This patch adds sparc32 sun4m SMP ECC memory controller support. Thanks, applied. I just moved the ecc_base after the other bases. > Three files are attached: > > The first is a diff to existing code. > The second is a diff for the new eccmemctl.c. Please use same level diff for all, this was suitable for patch -p1 and the first one for patch -p0. I'd recommend using quilt (or maybe git) for patch management, it will make your life easier. > The third is the openboot outputs for the 3 systems that support this chip. > > This patch is necessary for using sun openboot prom images because they > expect the device to be present and will fault when it's not there. > > A prom node will need to be added to openbios for this chip. Thanks, I used these attributes to define the node, mc-type is probed from the device. It seems that Linux and OpenBSD don't care about this device but NetBSD driver at least reads and prints the version.