From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Cc: kvm-devel@lists.sourceforge.net, kvm-ia64-devel@lists.sourceforge.net
Subject: Re: [Qemu-devel] Re: [kvm-devel] [PATCH] Making SLIRP code more 64-bit clean
Date: Wed, 30 Jan 2008 19:10:43 +0200 [thread overview]
Message-ID: <f43fc5580801300910w583f39br18d2c6e60e2370a3@mail.gmail.com> (raw)
In-Reply-To: <47A0A90B.50407@lanl.gov>
On 1/30/08, Scott Pakin <pakin@lanl.gov> wrote:
> Zhang, Xiantao wrote:
> > Scott Pakin wrote:
> >> The attached patch corrects a bug in qemu/slirp/tcp_var.h that defines
> >> the seg_next field in struct tcpcb to be 32 bits wide regardless of
> >> 32/64-bitness. seg_next is assigned a pointer value in
> >> qemu/slirp/tcp_subr.c, then cast back to a pointer in
> >> qemu/slirp/tcp_input.c and dereferenced. That produces a SIGSEGV on
> >> my system.
> >
> >
> > I still hit it on IA64 platform with your patch, once configured with
> > slirp.
>
> Okay, here's a more thorough patch that fixes *all* of the "cast from/to
> pointer to/from integer of a different size" mistakes that gcc warns
> about. Does it also solve the SIGSEGV problem on IA64?
The SLIRP code is much, much more subtle than that. Please see this thread:
http://lists.gnu.org/archive/html/qemu-devel/2007-10/msg00542.html
next prev parent reply other threads:[~2008-01-30 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 17:11 [Qemu-devel] [PATCH] Making SLIRP code more 64-bit clean Scott Pakin
2008-01-30 4:27 ` [Qemu-devel] RE: [kvm-devel] " Zhang, Xiantao
2008-01-30 16:42 ` [Qemu-devel] " Scott Pakin
2008-01-30 17:10 ` Blue Swirl [this message]
2008-02-01 1:26 ` [kvm-ia64-devel] [Qemu-devel] Re: [kvm-devel] [PATCH] MakingSLIRP " Zhang, Xiantao
2008-01-31 8:24 ` [Qemu-devel] RE: [kvm-devel] [PATCH] Making SLIRP " Zhang, Xiantao
2008-01-31 18:38 ` [Qemu-devel] " Scott Pakin
2008-02-01 1:37 ` Scott Pakin
2008-02-01 2:44 ` [Qemu-devel] RE: [kvm-ia64-devel] [kvm-devel] [PATCH] Making SLIRP code more64-bit clean Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580801300910w583f39br18d2c6e60e2370a3@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ia64-devel@lists.sourceforge.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).