From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JSaWu-0002mL-Pb for qemu-devel@nongnu.org; Fri, 22 Feb 2008 11:13:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JSaWt-0002kY-4e for qemu-devel@nongnu.org; Fri, 22 Feb 2008 11:13:44 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JSaWs-0002kK-TZ for qemu-devel@nongnu.org; Fri, 22 Feb 2008 11:13:42 -0500 Received: from nf-out-0910.google.com ([64.233.182.191]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JSaWs-00013b-Mv for qemu-devel@nongnu.org; Fri, 22 Feb 2008 11:13:42 -0500 Received: by nf-out-0910.google.com with SMTP id 30so282199nfu.12 for ; Fri, 22 Feb 2008 08:13:41 -0800 (PST) Message-ID: Date: Fri, 22 Feb 2008 18:13:40 +0200 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH, RFC, WIP] TCG for Qemu target Sparc32/64 In-Reply-To: <20080222000605.GB6462@networkno.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080222000605.GB6462@networkno.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel On 2/22/08, Thiemo Seufer wrote: > Blue Swirl wrote: > > The attached patch enables most TCG ops for Qemu Sparc32/64 target. > > Sparc32 softmmu and linux-user are OK, but Sparc64 and Sparc32plus > > targets do not work. > > > > Comments? > > > > It would be nice to get rid of T2 usage in std (also stda and > > casa/casxa) but I don't know how to pass a 64-bit value from legacy op > > to TCG stores and loads on a 32-bit target and host. [cut] > This whole lot should probably move to generic code (conditionalized on > TARGET_LONG_BITS), I have the same code in my MIPS prototype. I agree. Also these lines, if they are really needed: +#if TCG_TARGET_REG_BITS == 32 +#define tcg_gen_ld_ptr tcg_gen_ld_i32 +#else +#define tcg_gen_ld_ptr tcg_gen_ld_i64 +#endif