From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] FDC: simplify code [v2]
Date: Mon, 7 Apr 2008 20:38:20 +0300 [thread overview]
Message-ID: <f43fc5580804071038g69fbd8c6y9bdf8d96419995c@mail.gmail.com> (raw)
In-Reply-To: <47F8CD5A.7070907@reactos.org>
On 4/6/08, Hervé Poussineau <hpoussin@reactos.org> wrote:
> Hi,
>
> Attached patch prevents duplication of quite similar code in fdc.c, and so,
> removes 300 lines and 8KB of code.
> It first extracts implementation of FDC commands to separate methods, and
> then uses a table to know which method to execute instead of a big switch.
>
> This patch takes cares of Blue Swirl's comments, and replaces linear search
> by a direct table lookup.
I hate myself saying this, but the search version looked better. The
table is ugly. I didn't notice the different masks in the original or
the previous version, sorry.
prev parent reply other threads:[~2008-04-07 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 13:17 [Qemu-devel] [PATCH] FDC: simplify code [v2] Hervé Poussineau
2008-04-07 17:38 ` Blue Swirl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580804071038g69fbd8c6y9bdf8d96419995c@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).