From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JrDKM-0005zz-0v
	for qemu-devel@nongnu.org; Wed, 30 Apr 2008 10:30:34 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JrDKH-0005zb-I6
	for qemu-devel@nongnu.org; Wed, 30 Apr 2008 10:30:33 -0400
Received: from [199.232.76.173] (port=45105 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JrDKH-0005zW-BI
	for qemu-devel@nongnu.org; Wed, 30 Apr 2008 10:30:29 -0400
Received: from mu-out-0910.google.com ([209.85.134.191])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1JrDKH-0004t4-4s
	for qemu-devel@nongnu.org; Wed, 30 Apr 2008 10:30:29 -0400
Received: by mu-out-0910.google.com with SMTP id i10so154364mue.2
	for <qemu-devel@nongnu.org>; Wed, 30 Apr 2008 07:30:28 -0700 (PDT)
Message-ID: <f43fc5580804300730h3eef51a6o775bd96a45c487e5@mail.gmail.com>
Date: Wed, 30 Apr 2008 17:30:27 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)
In-Reply-To: <48186134.7070303@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4807514B.9040607@suse.de> <4815EE89.70407@suse.de>
	<1209459667.4328.7.camel@frecb07144> <48173591.9010609@suse.de>
	<1209484105.4248.27.camel@frecb07144> <48174B0B.5070904@suse.de>
	<1209487719.4248.43.camel@frecb07144> <48183A34.7030608@suse.de>
	<1209549574.4312.27.camel@frecb07144> <48186134.7070303@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>

On 4/30/08, Kevin Wolf <kwolf@suse.de> wrote:
> Laurent Vivier schrieb:
>
> > just a comment on the patch: perhaps you can call your field
> > "open_flags" instead of "flags", and perhaps you can merge your field
> > with "fd_open_flags" ?
> >
>
>  Here you are. ;-)

Maybe the alignment could be handled like AIO and synchronous IO
emulation layers are added in bdrv_register, but at open stage?