qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: Kevin Wolf <mail@kevin-wolf.de>
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)
Date: Thu, 1 May 2008 17:35:51 +0300	[thread overview]
Message-ID: <f43fc5580805010735m75c2e78ua4863dd2a7dddd4a@mail.gmail.com> (raw)
In-Reply-To: <200804302305.42741@kevin-wolf.de>

On 5/1/08, Kevin Wolf <mail@kevin-wolf.de> wrote:
> Am Mittwoch, 30. April 2008 16:30:27 schrieb Blue Swirl:
>
> > Maybe the alignment could be handled like AIO and synchronous IO
>  > emulation layers are added in bdrv_register, but at open stage?
>
>
> You mean to preserve the original pread if the file is opened without O_DIRECT
>  and replace it by the emulation function only if O_DIRECT is really used?

Right.

>  Certainly possible in some way (having a function pointer in BDRVRawState),
>  but this won't save us anything.
>
>  But maybe I'm just missing your point. How exactly do you want to handle
>  things and what does it improve?

Maybe it's slightly faster that way and it would be closer to how
other block emulations are handled. It's just an idea.

  reply	other threads:[~2008-05-01 14:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-17 13:31 [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT) Kevin Wolf
2008-04-28 15:34 ` Kevin Wolf
2008-04-29  9:01   ` Laurent Vivier
2008-04-29 14:49     ` Kevin Wolf
2008-04-29 15:48       ` Laurent Vivier
2008-04-29 16:21         ` Kevin Wolf
2008-04-29 16:48           ` Laurent Vivier
2008-04-30  9:21             ` Kevin Wolf
2008-04-30  9:59               ` Laurent Vivier
2008-04-30 12:08                 ` Kevin Wolf
2008-04-30 14:30                   ` Blue Swirl
2008-04-30 21:05                     ` Kevin Wolf
2008-05-01 14:35                       ` Blue Swirl [this message]
2008-05-01 17:55                         ` Kevin Wolf
2008-05-06  8:44                           ` Kevin Wolf
2008-05-06  9:02                             ` Laurent Vivier
2008-05-06 16:42                             ` Blue Swirl
2008-05-06 16:56                               ` Kevin Wolf
2008-05-06 17:23                                 ` Blue Swirl
2008-04-30  0:05           ` Jamie Lokier
2008-04-30  0:02       ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580805010735m75c2e78ua4863dd2a7dddd4a@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=mail@kevin-wolf.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).