From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Re: phys_ram_base, direct access to guest memory
Date: Fri, 2 May 2008 17:52:07 +0300 [thread overview]
Message-ID: <f43fc5580805020752v78358c9dl34e3ecb9b4bddbbe@mail.gmail.com> (raw)
In-Reply-To: <20080408184634.GA11492@volta.aurel32.net>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
On 4/8/08, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Tue, Mar 25, 2008 at 11:12:57AM +0000, Ian Jackson wrote:
> > I wrote:
> > > In the attached patch, I remove all the direct uses of phys_ram_base
> > > from hw/pc.c, except for those presently needed to construct the
> > > arguments to the vga init functions.
> >
> > Is there something wrong with my patch or the general approach ?
>
>
> It simply doesn't work. After applying it, I get:
>
>
> qemu: fatal: Trying to execute code outside RAM or ROM at 0x000a0000
I fixed the bug in the patch, cpu_physical_memory_write_rom must be
used instead of cpu_physical_memory_write. I also made the same
changes to Sparc32/64, they run fine. Does this version work for PC
targets?
[-- Attachment #2: phys_mem_ij.diff --]
[-- Type: plain/text, Size: 20184 bytes --]
next prev parent reply other threads:[~2008-05-02 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 14:47 [Qemu-devel] phys_ram_base, direct access to guest memory Ian Jackson
2008-03-17 15:52 ` [Qemu-devel] [PATCH] Remove most uses of phys_ram_base in hw/pc.c Ian Jackson
2008-03-25 11:12 ` [Qemu-devel] [PATCH] Re: phys_ram_base, direct access to guest memory Ian Jackson
2008-04-08 18:46 ` Aurelien Jarno
2008-05-02 14:52 ` Blue Swirl [this message]
2008-05-05 4:01 ` Aurelien Jarno
2008-05-13 16:11 ` Blue Swirl
2008-05-13 17:03 ` Fabrice Bellard
2008-05-13 18:05 ` Blue Swirl
2008-05-13 18:38 ` Fabrice Bellard
2008-03-17 17:23 ` [Qemu-devel] " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580805020752v78358c9dl34e3ecb9b4bddbbe@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).