From: "Blue Swirl" <blauwirbel@gmail.com>
To: Kevin Wolf <kwolf@suse.de>
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)
Date: Tue, 6 May 2008 20:23:33 +0300 [thread overview]
Message-ID: <f43fc5580805061023x744410dat9719c856368aa564@mail.gmail.com> (raw)
In-Reply-To: <48208DCA.4000706@suse.de>
On 5/6/08, Kevin Wolf <kwolf@suse.de> wrote:
> Blue Swirl schrieb:
>
> > Well, the patch looks OK. But I try to test the patches before I
> > commit and for this I don't know how. Could you give some example test
> > cases?
> >
>
> If you want to test that the patch fixes what it promises you only have to
> create a qcow or qcow2 image and start qemu with cache=off for this image.
> This will fail without the patch, and it should work with the patch applied.
> This covers the simple case. For the aio part of the patch you can try
> saving/loading of snapshots. Normal qcow2 operation doesn't trigger the aio
> code path.
Thanks, it seems to work.
next prev parent reply other threads:[~2008-05-06 17:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-17 13:31 [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT) Kevin Wolf
2008-04-28 15:34 ` Kevin Wolf
2008-04-29 9:01 ` Laurent Vivier
2008-04-29 14:49 ` Kevin Wolf
2008-04-29 15:48 ` Laurent Vivier
2008-04-29 16:21 ` Kevin Wolf
2008-04-29 16:48 ` Laurent Vivier
2008-04-30 9:21 ` Kevin Wolf
2008-04-30 9:59 ` Laurent Vivier
2008-04-30 12:08 ` Kevin Wolf
2008-04-30 14:30 ` Blue Swirl
2008-04-30 21:05 ` Kevin Wolf
2008-05-01 14:35 ` Blue Swirl
2008-05-01 17:55 ` Kevin Wolf
2008-05-06 8:44 ` Kevin Wolf
2008-05-06 9:02 ` Laurent Vivier
2008-05-06 16:42 ` Blue Swirl
2008-05-06 16:56 ` Kevin Wolf
2008-05-06 17:23 ` Blue Swirl [this message]
2008-04-30 0:05 ` Jamie Lokier
2008-04-30 0:02 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43fc5580805061023x744410dat9719c856368aa564@mail.gmail.com \
--to=blauwirbel@gmail.com \
--cc=Laurent.Vivier@bull.net \
--cc=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).