From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1JtQt8-0001uS-LE
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:23:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1JtQt6-0001u3-6W
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:23:38 -0400
Received: from [199.232.76.173] (port=52421 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1JtQt5-0001ts-Ut
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:23:36 -0400
Received: from gv-out-0910.google.com ([216.239.58.187])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1JtQt5-0003yG-Fv
	for qemu-devel@nongnu.org; Tue, 06 May 2008 13:23:35 -0400
Received: by gv-out-0910.google.com with SMTP id n8so215327gve.36
	for <qemu-devel@nongnu.org>; Tue, 06 May 2008 10:23:34 -0700 (PDT)
Message-ID: <f43fc5580805061023x744410dat9719c856368aa564@mail.gmail.com>
Date: Tue, 6 May 2008 20:23:33 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Align file accesses with cache=off (O_DIRECT)
In-Reply-To: <48208DCA.4000706@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <4807514B.9040607@suse.de> <200804302305.42741@kevin-wolf.de>
	<f43fc5580805010735m75c2e78ua4863dd2a7dddd4a@mail.gmail.com>
	<200805011955.00265@kevin-wolf.de> <48201A71.3040405@suse.de>
	<f43fc5580805060942p1d1edd18j30b5652a43aca656@mail.gmail.com>
	<48208DCA.4000706@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@suse.de>
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, qemu-devel@nongnu.org

On 5/6/08, Kevin Wolf <kwolf@suse.de> wrote:
> Blue Swirl schrieb:
>
> > Well, the patch looks OK. But I try to test the patches before I
> > commit and for this I don't know how. Could you give some example test
> > cases?
> >
>
>  If you want to test that the patch fixes what it promises you only have to
> create a qcow or qcow2 image and start qemu with cache=off for this image.
> This will fail without the patch, and it should work with the patch applied.
> This covers the simple case. For the aio part of the patch you can try
> saving/loading of snapshots. Normal qcow2 operation doesn't trigger the aio
> code path.

Thanks, it seems to work.