From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Jy9s3-0002Wq-PO
	for qemu-devel@nongnu.org; Mon, 19 May 2008 14:14:03 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Jy9s2-0002WA-23
	for qemu-devel@nongnu.org; Mon, 19 May 2008 14:14:03 -0400
Received: from [199.232.76.173] (port=40777 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Jy9s1-0002W5-VB
	for qemu-devel@nongnu.org; Mon, 19 May 2008 14:14:01 -0400
Received: from rv-out-0708.google.com ([209.85.198.240]:53563)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1Jy9s1-0002im-Fb
	for qemu-devel@nongnu.org; Mon, 19 May 2008 14:14:01 -0400
Received: by rv-out-0708.google.com with SMTP id f25so1311807rvb.22
	for <qemu-devel@nongnu.org>; Mon, 19 May 2008 11:14:00 -0700 (PDT)
Message-ID: <f43fc5580805191114h7b4a2a64y4fa7c288c4ea2c23@mail.gmail.com>
Date: Mon, 19 May 2008 21:14:00 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] Patch removing spaces
In-Reply-To: <Pine.LNX.4.64.0805192154500.12560@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <948556.48155.qm@web57013.mail.re3.yahoo.com>
	<18481.20318.581788.423619@mariner.uk.xensource.com>
	<Pine.LNX.4.64.0805192154500.12560@linmac.oyster.ru>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 5/19/08, malc <av1474@comtv.ru> wrote:
> On Mon, 19 May 2008, Ian Jackson wrote:
>
>
> > Balazs Attila-Mihaly \(Cd-MaN\) writes ("[Qemu-devel] Patch removing
> >
> > > spaces"): If anyone is interested: a patch which removes spaces from
> > > the end of the lines. Compressed because it's rather big.
> > >
> >
> > Please don't apply this patch!
> >
> > Spaces at the ends of lines are indeed irritating and we should avoid
> > them.  But going out of our way to remove them is definitely wrong -
> > it's reformatting, which is nearly always wrong in Free Software.
> >
> >
>
>  [..snip..]
>
>  Preventive measure that makes the code look sufficiently ugly when
>  tabs or trailing whitespace is present. Hands almost reflectively
>  reach for `M-x nuke-trailing-whitespace' and `C-x h M-x untabify'

No match for M-x nuke-trailing-whitespace, where is that?

>  (defface font-lock-ws-face
>   '((((class color) (background dark)) (:background "white"))
>     (((class color) (background light)) (:background "black"))
>     (t (:bold t)))
>   "Font Lock mode face used to highlight unwated whitespace."
>   :group 'font-lock-faces)
>  (setq font-lock-ws-face 'font-lock-ws-face)
>
>  (defun font-lock-mode-hook-fn ()
>   (setq old-font-lock-keywords font-lock-keywords)
>   (make-variable-buffer-local 'font-lock-keywords)
>   (let ((elem
>          (list
>           (list "\\([ \t]+$\\)\\|\\(\t\\)"
>                 (list 0 font-lock-ws-face)))))
>     (setq font-lock-keywords (append font-lock-keywords elem))))
>
>  (add-hook 'font-lock-mode-hook 'font-lock-mode-hook-fn)

Thanks, it's ugly!