From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K11fh-0005PI-Ie
	for qemu-devel@nongnu.org; Tue, 27 May 2008 12:05:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K11ff-0005N9-S6
	for qemu-devel@nongnu.org; Tue, 27 May 2008 12:05:09 -0400
Received: from [199.232.76.173] (port=50954 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K11fe-0005Mq-Sw
	for qemu-devel@nongnu.org; Tue, 27 May 2008 12:05:07 -0400
Received: from wf-out-1314.google.com ([209.85.200.175]:15809)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1K11fe-0007Gi-Oj
	for qemu-devel@nongnu.org; Tue, 27 May 2008 12:05:07 -0400
Received: by wf-out-1314.google.com with SMTP id 27so2173691wfd.4
	for <qemu-devel@nongnu.org>; Tue, 27 May 2008 09:05:03 -0700 (PDT)
Message-ID: <f43fc5580805270905sa5d9385lbbe0be82db677db8@mail.gmail.com>
Date: Tue, 27 May 2008 19:05:03 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/6] simplify cpu_exec
In-Reply-To: <200805271633.51342.paul@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1211901505-30519-1-git-send-email-gcosta@redhat.com>
	<1211901505-30519-2-git-send-email-gcosta@redhat.com>
	<200805271633.51342.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org, Glauber Costa <gcosta@redhat.com>

On 5/27/08, Paul Brook <paul@codesourcery.com> wrote:
> > +void cpu_load_flags(CPUState *env);
>  > +void cpu_put_flags(CPUState *env);
>
>
> These really need a comment saying what they do. The names are not at all
>  intuitive. Also, why load/put? I'd expect load/save/store or get/put.
>
>
>  > +#if defined(reg_REGWPTR)
>  > +static uint32_t *saved_regwptr;
>  > +#endif
>
>
> Eww. You've replaced reasonably self contained local code with a global
>  variable hidden deep in target specific code. I plan on adding multithreaded
>  qemu support soon, so this is a non-starter.

REGWPTR code can be removed, it's not used now.