From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KGyC6-0007ow-Su for qemu-devel@nongnu.org; Thu, 10 Jul 2008 11:36:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KGyC3-0007m7-Rb for qemu-devel@nongnu.org; Thu, 10 Jul 2008 11:36:30 -0400 Received: from [199.232.76.173] (port=49124 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KGyC3-0007m4-NM for qemu-devel@nongnu.org; Thu, 10 Jul 2008 11:36:27 -0400 Received: from wf-out-1314.google.com ([209.85.200.173]:7181) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KGyC3-0002cc-ER for qemu-devel@nongnu.org; Thu, 10 Jul 2008 11:36:27 -0400 Received: by wf-out-1314.google.com with SMTP id 27so3287681wfd.4 for ; Thu, 10 Jul 2008 08:36:25 -0700 (PDT) Message-ID: Date: Thu, 10 Jul 2008 18:36:25 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] RFC: ARM prologue linkage fix In-Reply-To: <200807082143.48545.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_10318_3235895.1215704185514" References: <200807082143.48545.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: qemu-devel@nongnu.org ------=_Part_10318_3235895.1215704185514 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 7/8/08, Paul Brook wrote: > On Tuesday 08 July 2008, Blue Swirl wrote: > > Hi, > > > > I made a patch which allows sparc-linux-user target to be linked on an > > ARM host. Is this OK? Sparc32 helloworld program runs successfully, > > otherwise untested. > > > In principle it looks ok, however: > > I think it deserves a comment in exec.c saying why we do this - the prologue > is reached via a direct jump, so must be placed close to the code segment. > > Also, calling something .bss.code_gen, than placing it is .data is just asking > for trouble :-) I suggest calling the section ".gen_code". Is this version OK then? Should I commit it? ------=_Part_10318_3235895.1215704185514 Content-Type: plain/text; name=fix_arm_prologue.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fihiucs5 Content-Disposition: attachment; filename=fix_arm_prologue.diff SW5kZXg6IHFlbXUvYXJtLmxkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9hcm0ubGQJMjAwOC0w Ny0wOCAxODo0ODo0OS4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvYXJtLmxkCTIwMDgtMDctMTAg MTU6MzM6NDQuMDAwMDAwMDAwICswMDAwCkBAIC02Myw2ICs2Myw3IEBACiAgIC4gPSBBTElHTigw eDEwMDAwMCkgKyAoLiAmICgweDEwMDAwMCAtIDEpKTsKICAgLmRhdGEgICAgOgogICB7CisgICAg KiguZ2VuX2NvZGUpCiAgICAgKiguZGF0YSkKICAgICAqKC5nbnUubGlua29uY2UuZCopCiAgICAg Q09OU1RSVUNUT1JTCkluZGV4OiBxZW11L2V4ZWMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBxZW11Lm9yaWcv ZXhlYy5jCTIwMDgtMDctMDggMTg6NTA6MjkuMDAwMDAwMDAwICswMDAwCisrKyBxZW11L2V4ZWMu YwkyMDA4LTA3LTEwIDE1OjM0OjA5LjAwMDAwMDAwMCArMDAwMApAQCAtODksNyArODksMTkgQEAK IC8qIGFueSBhY2Nlc3MgdG8gdGhlIHRicyBvciB0aGUgcGFnZSB0YWJsZSBtdXN0IHVzZSB0aGlz IGxvY2sgKi8KIHNwaW5sb2NrX3QgdGJfbG9jayA9IFNQSU5fTE9DS19VTkxPQ0tFRDsKIAotdWlu dDhfdCBjb2RlX2dlbl9wcm9sb2d1ZVsxMDI0XSBfX2F0dHJpYnV0ZV9fKChhbGlnbmVkICgzMikp KTsKKyNpZiBkZWZpbmVkKF9fYXJtX18pCisvKiBPbiBBUk0gKGFsc28gUFBDIGFuZCBTcGFyYz8p IHByb2xvZ3VlIG11c3QgYmUgcmVhY2hhYmxlIHdpdGggYQorIGRpcmVjdCBqdW1wICh3aGljaCBo YXMgMjQgYml0IHJhbmdlKSwgc28gcGxhY2UgaXQgaW4gYSBzZWN0aW9uIGNsb3NlCisgdG8gY29k ZSBzZWdtZW50LiAqLworI2RlZmluZSBjb2RlX2dlbl9zZWN0aW9uICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBcCisgICAgX19hdHRyaWJ1dGVfXygoX19zZWN0aW9uX18oIi5nZW5fY29k ZSIpKSkgICAgICAgICAgIFwKKyAgICBfX2F0dHJpYnV0ZV9fKChhbGlnbmVkICgzMikpKQorI2Vs c2UKKyNkZWZpbmUgY29kZV9nZW5fc2VjdGlvbiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgXAorICAgIF9fYXR0cmlidXRlX18oKGFsaWduZWQgKDMyKSkpCisjZW5kaWYKKwordWludDhf dCBjb2RlX2dlbl9wcm9sb2d1ZVsxMDI0XSBjb2RlX2dlbl9zZWN0aW9uOwogdWludDhfdCAqY29k ZV9nZW5fYnVmZmVyOwogdW5zaWduZWQgbG9uZyBjb2RlX2dlbl9idWZmZXJfc2l6ZTsKIC8qIHRo cmVzaG9sZCB0byBmbHVzaCB0aGUgdHJhbnNsYXRlZCBjb2RlIGJ1ZmZlciAqLwo= ------=_Part_10318_3235895.1215704185514--