From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KOFXS-0000D5-I1 for qemu-devel@nongnu.org; Wed, 30 Jul 2008 13:32:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KOFXR-0000Bo-NO for qemu-devel@nongnu.org; Wed, 30 Jul 2008 13:32:38 -0400 Received: from [199.232.76.173] (port=40278 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KOFXR-0000BU-BA for qemu-devel@nongnu.org; Wed, 30 Jul 2008 13:32:37 -0400 Received: from wf-out-1314.google.com ([209.85.200.175]:34434) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KOFXQ-0004IL-OG for qemu-devel@nongnu.org; Wed, 30 Jul 2008 13:32:37 -0400 Received: by wf-out-1314.google.com with SMTP id 27so184613wfd.4 for ; Wed, 30 Jul 2008 10:32:35 -0700 (PDT) Message-ID: Date: Wed, 30 Jul 2008 20:32:35 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] Re: [PATCH 0/3]: Add UUID command-line option In-Reply-To: <20080729195048.GC11061@minantech.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_49618_21373230.1217439155747" References: <488DC8B2.1070009@redhat.com> <20080728141515.GJ3196@minantech.com> <488DD98D.5010907@codemonkey.ws> <20080728153527.GA23771@minantech.com> <488F6E0E.2070504@codemonkey.ws> <20080729195048.GC11061@minantech.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Chris Lalancette ------=_Part_49618_21373230.1217439155747 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 7/29/08, Gleb Natapov wrote: > On Tue, Jul 29, 2008 at 02:22:54PM -0500, Anthony Liguori wrote: > > Gleb Natapov wrote: > >> On Mon, Jul 28, 2008 at 09:37:01AM -0500, Anthony Liguori wrote: > >> > >>> The backdoor interface is deprecated (from a VMware perspective) and > >>> is pretty terrible. I'll go through and do a more thorough review > >>> of the patches Chris posted but one thing I already know I'd like to > >>> see the > >> Review my last submission I linked above then too. > >> > > > > Applying the -uuid support without making use of that uuid anywhere > > isn't very useful. > > > > You can read it from monitor, so management software can benefit from > it. And this will reduce my patch backlog :) > > > >>> UUID plumbed through the SMBIOS tables for x86. That's a requirement > >>> in my mind for adding a -uuid option. I see no harm in also > >>> supporting the backdoor interface but the primary way to expose a > >>> UUID should be SMBIOS. > >>> > >> I am not sure I understand what you mean. Currently SMBIOS tables are > >> built by bochs bios and UUID backdoor is needed to fill in missing info. > >> > > > > But that patch that got pushed into the Bochs BIOS was wrong. > > > > So here's what I'd like to see in order to apply these patches: > > > > 1) A new patch to the Bochs BIOS that used CMOS to pass a UUID (or > > possibly an OF data structure as Blue Swirl suggested--although CMOS is > > safer). > > We will run out of space in CMOS quickly if we will use it as qemu->bios > communication channel. Is passing pointer to memory location (Blue Swirl > suggestion) acceptable solution by everyone? Here's a patch implementing a configuration ROM (probably in a bad address) including a fake UUID. I skipped the more difficult parts like kernel address etc. ------=_Part_49618_21373230.1217439155747 Content-Type: plain/text; name=pc_use_firmware_abi.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fja7rfrp Content-Disposition: attachment; filename=pc_use_firmware_abi.diff SW5kZXg6IHFlbXUvaHcvcGMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBxZW11Lm9yaWcvaHcvcGMuYwkyMDA4 LTA3LTMwIDE2OjU4OjAzLjAwMDAwMDAwMCArMDAwMAorKysgcWVtdS9ody9wYy5jCTIwMDgtMDct MzAgMTc6MjQ6MDEuMDAwMDAwMDAwICswMDAwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAi c21idXMuaCIKICNpbmNsdWRlICJib2FyZHMuaCIKICNpbmNsdWRlICJjb25zb2xlLmgiCisjaW5j bHVkZSAiZmlybXdhcmVfYWJpLmgiCiAKIC8qIG91dHB1dCBCb2NocyBiaW9zIGluZm8gbWVzc2Fn ZXMgKi8KIC8vI2RlZmluZSBERUJVR19CSU9TCkBAIC00MSw2ICs0Miw4IEBACiAjZGVmaW5lIFZH QUJJT1NfQ0lSUlVTX0ZJTEVOQU1FICJ2Z2FiaW9zLWNpcnJ1cy5iaW4iCiAKICNkZWZpbmUgUENf TUFYX0JJT1NfU0laRSAoNCAqIDEwMjQgKiAxMDI0KQorI2RlZmluZSBQQ19DRkdfUk9NX0FERFIg MHhmMDAwMDAwMAorI2RlZmluZSBQQ19DRkdfUk9NX1NJWkUgNDA5NgogCiAvKiBMZWF2ZSBhIGNo dW5rIG9mIG1lbW9yeSBhdCB0aGUgdG9wIG9mIFJBTSBmb3IgdGhlIEJJT1MgQUNQSSB0YWJsZXMu ICAqLwogI2RlZmluZSBBQ1BJX0RBVEFfU0laRSAgICAgICAweDEwMDAwCkBAIC03MTIsNiArNzE1 LDU1IEBACiAgICAgbmJfbmUyaysrOwogfQogCitzdGF0aWMgaW50IHBjX2NmZ19yb21fc2V0X3Bh cmFtcyhyYW1fYWRkcl90IGNmZ19yb20sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb25zdCBjaGFyICphcmNoLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmFt X2FkZHJfdCBiZWxvd180Z19tZW1fc2l6ZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHJhbV9hZGRyX3QgYWJvdmVfNGdfbWVtX3NpemUsCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb25zdCBjaGFyICpib290X2RldmljZXMpCit7CisgICAgdWludDMyX3Qgc3Rh cnQ7CisgICAgdWludDhfdCBpbWFnZVtQQ19DRkdfUk9NX1NJWkVdOworICAgIG9od2NmZ192M190 ICpoZWFkZXIgPSAob2h3Y2ZnX3YzX3QgKikmaW1hZ2U7CisgICAgc3RydWN0IHBjX2FyY2hfY2Zn ICpwY19oZWFkZXI7CisgICAgZXh0ZXJuIGludCBub2dyYXBoaWM7CisKKyAgICBtZW1zZXQoaW1h Z2UsICdcMCcsIHNpemVvZihpbWFnZSkpOworCisgICAgLy8gVHJ5IHRvIG1hdGNoIFBQQyBOVlJB TQorICAgIHN0cmNweSgoY2hhciAqKWhlYWRlci0+c3RydWN0X2lkZW50LCAiUUVNVV9CSU9TIik7 CisgICAgaGVhZGVyLT5zdHJ1Y3RfdmVyc2lvbiA9IGNwdV90b19sZTMyKDMpOyAvKiBzdHJ1Y3R1 cmUgdjMgKi8KKworICAgIGhlYWRlci0+bnZyYW1fYXJjaF9wdHIgPSBjcHVfdG9fbGUxNihzaXpl b2Yob2h3Y2ZnX3YzX3QpKTsKKyAgICBoZWFkZXItPm52cmFtX2FyY2hfc2l6ZSA9IGNwdV90b19s ZTE2KHNpemVvZihzdHJ1Y3QgcGNfYXJjaF9jZmcpKTsKKyAgICBzdHJjcHkoKGNoYXIgKiloZWFk ZXItPmFyY2gsIGFyY2gpOworICAgIGhlYWRlci0+bmJfY3B1cyA9IHNtcF9jcHVzICYgMHhmZjsK KyAgICBoZWFkZXItPlJBTTBfYmFzZSA9IDA7CisgICAgaGVhZGVyLT5SQU0wX3NpemUgPSBjcHVf dG9fbGU2NCgodWludDY0X3QpYmVsb3dfNGdfbWVtX3NpemUpOworICAgIGlmIChhYm92ZV80Z19t ZW1fc2l6ZSkgeworICAgICAgICBoZWFkZXItPlJBTTFfYmFzZSA9IDB4MTAwMDAwMDAwVUxMOwor ICAgICAgICBoZWFkZXItPlJBTTFfc2l6ZSA9IGNwdV90b19sZTY0KCh1aW50NjRfdClhYm92ZV80 Z19tZW1fc2l6ZSk7CisgICAgfQorICAgIHN0cmNweSgoY2hhciAqKWhlYWRlci0+Ym9vdF9kZXZp Y2VzLCBib290X2RldmljZXMpOworICAgIGhlYWRlci0+bmJvb3RfZGV2aWNlcyA9IHN0cmxlbihi b290X2RldmljZXMpICYgMHhmZjsKKworICAgIGlmIChub2dyYXBoaWMpCisgICAgICAgIGhlYWRl ci0+Z3JhcGhpY19mbGFncyA9IGNwdV90b19sZTE2KE9IV19HRl9OT0dSQVBISUNTKTsKKworICAg IHN0cm5jcHkoKGNoYXIgKiloZWFkZXItPnV1aWQsICJRRU1VUUVNVVFFTVVRRU1VIiwgMTYpOwor CisgICAgaGVhZGVyLT5jcmMgPSBjcHVfdG9fbGUxNihPSFdfY29tcHV0ZV9jcmMoaGVhZGVyLCAw eDAwLCAweEY4KSk7CisKKyAgICAvLyBBcmNoaXRlY3R1cmUgc3BlY2lmaWMgaGVhZGVyCisgICAg c3RhcnQgPSBzaXplb2Yob2h3Y2ZnX3YzX3QpOworICAgIHBjX2hlYWRlciA9IChzdHJ1Y3QgcGNf YXJjaF9jZmcgKikmaW1hZ2Vbc3RhcnRdOworICAgIHBjX2hlYWRlci0+dmFsaWQgPSAxOworICAg IHN0YXJ0ICs9IHNpemVvZihzdHJ1Y3QgcGNfYXJjaF9jZmcpOworCisgICAgY3B1X3BoeXNpY2Fs X21lbW9yeV93cml0ZV9yb20oY2ZnX3JvbSwgaW1hZ2UsIHNpemVvZihpbWFnZSkpOworCisgICAg cmV0dXJuIDA7Cit9CisKIC8qIFBDIGhhcmR3YXJlIGluaXRpYWxpc2F0aW9uICovCiBzdGF0aWMg dm9pZCBwY19pbml0MShyYW1fYWRkcl90IHJhbV9zaXplLCBpbnQgdmdhX3JhbV9zaXplLAogICAg ICAgICAgICAgICAgICAgICAgY29uc3QgY2hhciAqYm9vdF9kZXZpY2UsIERpc3BsYXlTdGF0ZSAq ZHMsCkBAIC03MjMsNiArNzc1LDcgQEAKICAgICBpbnQgcmV0LCBsaW51eF9ib290LCBpOwogICAg IHJhbV9hZGRyX3QgcmFtX2FkZHIsIHZnYV9yYW1fYWRkciwgYmlvc19vZmZzZXQsIHZnYV9iaW9z X29mZnNldDsKICAgICByYW1fYWRkcl90IGJlbG93XzRnX21lbV9zaXplLCBhYm92ZV80Z19tZW1f c2l6ZSA9IDA7CisgICAgcmFtX2FkZHJfdCBjZmdfcm9tX29mZnNldDsKICAgICBpbnQgYmlvc19z aXplLCBpc2FfYmlvc19zaXplLCB2Z2FfYmlvc19zaXplOwogICAgIFBDSUJ1cyAqcGNpX2J1czsK ICAgICBpbnQgcGlpeDNfZGV2Zm4gPSAtMTsKQEAgLTg2Nyw2ICs5MjAsMTQgQEAKICAgICBjcHVf cmVnaXN0ZXJfcGh5c2ljYWxfbWVtb3J5KCh1aW50MzJfdCkoLWJpb3Nfc2l6ZSksCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBiaW9zX3NpemUsIGJpb3Nfb2Zmc2V0IHwgSU9fTUVN X1JPTSk7CiAKKyAgICAvKiBtYXAgY29uZmlndXJhdGlvbiBST00gKi8KKyAgICBjZmdfcm9tX29m ZnNldCA9IHFlbXVfcmFtX2FsbG9jKFBDX0NGR19ST01fU0laRSk7CisgICAgY3B1X3JlZ2lzdGVy X3BoeXNpY2FsX21lbW9yeShQQ19DRkdfUk9NX0FERFIsIFBDX0NGR19ST01fU0laRSwKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNmZ19yb21fb2Zmc2V0IHwgSU9fTUVNX1JPTSk7 CisgICAgcGNfY2ZnX3JvbV9zZXRfcGFyYW1zKFBDX0NGR19ST01fQUREUiwgcGNpX2VuYWJsZWQ/ ICJwYyIgOiAiaXNhcGMiLAorICAgICAgICAgICAgICAgICAgICAgICAgICBiZWxvd180Z19tZW1f c2l6ZSwgYWJvdmVfNGdfbWVtX3NpemUsCisgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf ZGV2aWNlKTsKKwogICAgIGJvY2hzX2Jpb3NfaW5pdCgpOwogCiAgICAgaWYgKGxpbnV4X2Jvb3Qp CkluZGV4OiBxZW11L2h3L2Zpcm13YXJlX2FiaS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUub3JpZy9o dy9maXJtd2FyZV9hYmkuaAkyMDA4LTA3LTMwIDE2OjU3OjUzLjAwMDAwMDAwMCArMDAwMAorKysg cWVtdS9ody9maXJtd2FyZV9hYmkuaAkyMDA4LTA3LTMwIDE3OjIyOjEyLjAwMDAwMDAwMCArMDAw MApAQCAtNTQsOCArNTQsMTAgQEAKICAgICB1aW50OF90ICBwYWQzWzVdOwogICAgIC8qIDB4RDA6 IGJvb3QgZGV2aWNlcyAgICAgICAgICAgICAgICAgICAgICAgICAgICAqLwogICAgIHVpbnQ4X3Qg IGJvb3RfZGV2aWNlc1sweDEwXTsKLSAgICAvKiAweEUwICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKi8KLSAgICB1aW50OF90ICBwYWQ0WzB4MUNdOyAvKiAyOCAqLwor ICAgIC8qIDB4RTA6IFVVSUQgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqLwor ICAgIHVpbnQ4X3QgIHV1aWRbMHgxMF07CisgICAgLyogMHhGMCAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICovCisgICAgdWludDhfdCAgcGFkNFsweENdOyAvKiAxMiAq LwogICAgIC8qIDB4RkM6IGNoZWNrc3VtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAq LwogICAgIHVpbnQxNl90IGNyYzsKICAgICB1aW50OF90ICBwYWQ1WzB4MDJdOwpAQCAtMTc2LDYg KzE3OCwxMiBAQAogICAgIGhlYWRlci0+Y2hlY2tzdW0gPSB0bXA7CiB9CiAKKy8qIFBDIGNvbmZp Z3VyYXRpb24gc3RydWN0dXJlICovCitzdHJ1Y3QgcGNfYXJjaF9jZmcgeworICAgIHVpbnQ4X3Qg dmFsaWQ7CisgICAgdWludDhfdCB1bnVzZWRbNjNdOworfTsKKwogI2Vsc2UgLyogX19BU1NFTUJM WV9fICovCiAKIC8qIFN0cnVjdHVyZSBvZmZzZXRzIGZvciBhc20gdXNlICovCkluZGV4OiBxZW11 L2h3L3N1bjRtLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2h3L3N1bjRtLmMJMjAwOC0wNy0z MCAxNzoyNDoxNC4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvaHcvc3VuNG0uYwkyMDA4LTA3LTMw IDE3OjI0OjU2LjAwMDAwMDAwMCArMDAwMApAQCAtMjEzLDYgKzIxMyw4IEBACiAgICAgaWYgKG5v Z3JhcGhpYykKICAgICAgICAgaGVhZGVyLT5ncmFwaGljX2ZsYWdzID0gY3B1X3RvX2JlMTYoT0hX X0dGX05PR1JBUEhJQ1MpOwogCisgICAgc3RybmNweSgoY2hhciAqKWhlYWRlci0+dXVpZCwgIlFF TVVRRU1VUUVNVVFFTVUiLCAxNik7CisKICAgICBoZWFkZXItPmNyYyA9IGNwdV90b19iZTE2KE9I V19jb21wdXRlX2NyYyhoZWFkZXIsIDB4MDAsIDB4RjgpKTsKIAogICAgIC8vIEFyY2hpdGVjdHVy ZSBzcGVjaWZpYyBoZWFkZXIKSW5kZXg6IHFlbXUvaHcvc3VuNHUuYwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBx ZW11Lm9yaWcvaHcvc3VuNHUuYwkyMDA4LTA3LTMwIDE3OjI0OjE2LjAwMDAwMDAwMCArMDAwMAor KysgcWVtdS9ody9zdW40dS5jCTIwMDgtMDctMzAgMTc6MjQ6MzMuMDAwMDAwMDAwICswMDAwCkBA IC0xNDQsNiArMTQ0LDggQEAKICAgICBpZiAobm9ncmFwaGljKQogICAgICAgICBoZWFkZXItPmdy YXBoaWNfZmxhZ3MgPSBjcHVfdG9fYmUxNihPSFdfR0ZfTk9HUkFQSElDUyk7CiAKKyAgICBzdHJu Y3B5KChjaGFyICopaGVhZGVyLT51dWlkLCAiUUVNVVFFTVVRRU1VUUVNVSIsIDE2KTsKKwogICAg IGhlYWRlci0+Y3JjID0gY3B1X3RvX2JlMTYoT0hXX2NvbXB1dGVfY3JjKGhlYWRlciwgMHgwMCwg MHhGOCkpOwogCiAgICAgLy8gQXJjaGl0ZWN0dXJlIHNwZWNpZmljIGhlYWRlcgo= ------=_Part_49618_21373230.1217439155747--