From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ30m-0004dS-F7
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:34:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ30k-0004dD-Tr
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:34:20 -0400
Received: from [199.232.76.173] (port=43986 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ30k-0004dA-PF
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:34:18 -0400
Received: from wf-out-1314.google.com ([209.85.200.173]:35289)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KQ30k-0003BZ-I7
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:34:18 -0400
Received: by wf-out-1314.google.com with SMTP id 27so3336462wfd.4
	for <qemu-devel@nongnu.org>; Mon, 04 Aug 2008 09:34:16 -0700 (PDT)
Message-ID: <f43fc5580808040934p187107ffu1b035c5297c1b25a@mail.gmail.com>
Date: Mon, 4 Aug 2008 19:34:16 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support
In-Reply-To: <1217865045-10722-2-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>
	<1217865045-10722-2-git-send-email-kraxel@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>  - allow xenpv machines run without disk and kernel specified
>   by adding a nodisk_ok field to QEMUMachine.

Nice idea, this would be a useful feature by itself.

>  +  $(XEN_OBJS) : CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes

These aren't needed for Xen. Though I wonder why at least -Wall
-Wstrict-prototypes could not be added globally.

>  +    if (-1 != xen_present)

This style looks alien to me. Do you really find it readable?