From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ3Id-0004Qw-IE
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:52:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ3Ic-0004Qk-58
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:52:47 -0400
Received: from [199.232.76.173] (port=53097 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ3Ic-0004Qf-2O
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:52:46 -0400
Received: from wf-out-1314.google.com ([209.85.200.172]:38990)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KQ3Ib-0007Os-TB
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 12:52:46 -0400
Received: by wf-out-1314.google.com with SMTP id 27so3345180wfd.4
	for <qemu-devel@nongnu.org>; Mon, 04 Aug 2008 09:52:44 -0700 (PDT)
Message-ID: <f43fc5580808040952o7dc14337i864978b0df2623f3@mail.gmail.com>
Date: Mon, 4 Aug 2008 19:52:44 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.
In-Reply-To: <1217865045-10722-4-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>
	<1217865045-10722-4-git-send-email-kraxel@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>  +       buffer->data = realloc(buffer->data, buffer->capacity);

On Qemu, instead of malloc,  qemu_malloc should be used to allocate
memory. Though there isn't qemu_realloc.

>  +    if (!type || 0 != strcmp(type, "ioemu")) {

Shouldn't this be "qemu"?