From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ3Yk-0006LI-MP
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:09:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ3Yj-0006L0-Ju
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:09:26 -0400
Received: from [199.232.76.173] (port=46675 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ3Yj-0006Kx-G4
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:09:25 -0400
Received: from yx-out-1718.google.com ([74.125.44.152]:42622)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KQ3Yj-0002cf-FO
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:09:25 -0400
Received: by yx-out-1718.google.com with SMTP id 3so171946yxi.82
	for <qemu-devel@nongnu.org>; Mon, 04 Aug 2008 10:09:24 -0700 (PDT)
Message-ID: <f43fc5580808041009g727f9f59gff94e27decfe2d25@mail.gmail.com>
Date: Mon, 4 Aug 2008 20:09:23 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver
In-Reply-To: <1217865045-10722-5-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>
	<1217865045-10722-5-git-send-email-kraxel@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>  +const unsigned char atkbd_set2_keycode[512] = {

Missing "static"?

>  +const unsigned char atkbd_unxlate_table[128] = {

Ditto.

>  +       for (i = 0; i < 128; i++) {
>  +           scancode2linux[i] = atkbd_set2_keycode[atkbd_unxlate_table[i]];
>  +           scancode2linux[i | 0x80] =
>  +               atkbd_set2_keycode[atkbd_unxlate_table[i] | 0x80];
>  +       }

Can't these table be calculated so that this initial run-time lookup
is not needed?

The framebuffer does not use dirty memory detection. Is this
intentional? I understand that in Xen that's not possible.