From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ3pV-00018y-Kb
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:26:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ3pU-00018N-D7
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:26:44 -0400
Received: from [199.232.76.173] (port=40275 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ3pU-00018G-6Q
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:26:44 -0400
Received: from wf-out-1314.google.com ([209.85.200.168]:43862)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KQ3pU-0005dh-6R
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 13:26:44 -0400
Received: by wf-out-1314.google.com with SMTP id 27so3360951wfd.4
	for <qemu-devel@nongnu.org>; Mon, 04 Aug 2008 10:26:42 -0700 (PDT)
Message-ID: <f43fc5580808041026t49c8962fhe6ef926608e3db6c@mail.gmail.com>
Date: Mon, 4 Aug 2008 20:26:42 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver.
In-Reply-To: <1217865045-10722-6-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>
	<1217865045-10722-6-git-send-email-kraxel@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: xen-devel@lists.xensource.com, Gerd Hoffmann <kraxel@redhat.com>

On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
>  +/* i386 protocol version */
>  +#pragma pack(push, 4)

What's wrong with __attribute__(__aligned__)?

>  + *  FIXME: the code is designed to handle multiple outstanding
>  + *  requests (using aio or using threads), which isn't used right
>  + *  now due to limitations of the qemu block driver interface.

Yes, what happened to vectored DMA patches?

>  +    RING_PUSH_RESPONSES_AND_CHECK_NOTIFY(&blkdev->rings.common, send_notify);

EUGLY_LONG_NAME_WITH_ALL_CAPS

>  +       mode   = O_RDONLY;
>  +       qflags = BDRV_O_RDONLY;
>  +       info  |= VDISK_READONLY | VDISK_REMOVABLE | VDISK_CDROM;

Does this mean that all read-only disks are assumed to be CDROMs or
that all removable disks are read-only?

Why IF_XEN?

Why different protocols for i386 and x86_64? Would I need to add
Sparc32 and Sparc64 versions some day?