From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KQ6vp-0006AE-93
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:45:29 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KQ6vn-00069u-Mw
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:45:28 -0400
Received: from [199.232.76.173] (port=38004 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KQ6vn-00069r-K3
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:45:27 -0400
Received: from py-out-1112.google.com ([64.233.166.177]:49960)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KQ6vn-0004Ds-3W
	for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:45:27 -0400
Received: by py-out-1112.google.com with SMTP id p76so1174489pyb.10
	for <qemu-devel@nongnu.org>; Mon, 04 Aug 2008 13:45:26 -0700 (PDT)
Message-ID: <f43fc5580808041345v729d4303ye4273d56a7c139eb@mail.gmail.com>
Date: Mon, 4 Aug 2008 23:45:25 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] xen: blk & nic configuration via cmd
	line.
In-Reply-To: <4897468A.7050009@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1217865045-10722-1-git-send-email-kraxel@redhat.com>
	<1217865045-10722-8-git-send-email-kraxel@redhat.com>
	<f43fc5580808041035u54e4c8a6v89901db73b6eaf59@mail.gmail.com>
	<4897468A.7050009@redhat.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

On 8/4/08, Gerd Hoffmann <kraxel@redhat.com> wrote:
> Blue Swirl wrote:
>  >>  +    /* config cleanup hook */
>  >>  +    atexit(xen_config_cleanup);
>  >
>  > I'd put this in vl.c, it's not machine specific.
>
>
> It actually is because it cleans up stuff only created for the xenpv
>  machine type.  Moving it to vl.c doesn't hurt, I would have to wrap it
>  into "#ifdef CONFIG_XEN" though ...

I was thinking that for example Sparc32/64 would need another machine,
but it looks like the changes could be small and all CPUs could use
the same xenpv machine type. So it's fine as it is now.