From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQ6xU-0006fP-D2 for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:47:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQ6xT-0006ep-Fl for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:47:11 -0400 Received: from [199.232.76.173] (port=57683 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQ6xS-0006ei-VG for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:47:11 -0400 Received: from wf-out-1314.google.com ([209.85.200.174]:13852) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQ6xS-0004O7-L0 for qemu-devel@nongnu.org; Mon, 04 Aug 2008 16:47:10 -0400 Received: by wf-out-1314.google.com with SMTP id 27so3468612wfd.4 for ; Mon, 04 Aug 2008 13:47:09 -0700 (PDT) Message-ID: Date: Mon, 4 Aug 2008 23:47:09 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver. In-Reply-To: <4897472A.1070100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1217865045-10722-1-git-send-email-kraxel@redhat.com> <1217865045-10722-4-git-send-email-kraxel@redhat.com> <4897472A.1070100@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 8/4/08, Gerd Hoffmann wrote: > Blue Swirl wrote: > > On 8/4/08, Gerd Hoffmann wrote: > >> + buffer->data = realloc(buffer->data, buffer->capacity); > > > > On Qemu, instead of malloc, qemu_malloc should be used to allocate > > memory. Though there isn't qemu_realloc. > > > Should I add qemu_realloc then? That would be nice, but changing also all reallocs to qemu_realloc calls for a new patch.