From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQlq9-0002mi-FN for qemu-devel@nongnu.org; Wed, 06 Aug 2008 12:26:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQlq7-0002jG-Pi for qemu-devel@nongnu.org; Wed, 06 Aug 2008 12:26:21 -0400 Received: from [199.232.76.173] (port=58460 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQlq7-0002ix-K6 for qemu-devel@nongnu.org; Wed, 06 Aug 2008 12:26:19 -0400 Received: from wf-out-1314.google.com ([209.85.200.172]:54233) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQlq7-0000le-CC for qemu-devel@nongnu.org; Wed, 06 Aug 2008 12:26:19 -0400 Received: by wf-out-1314.google.com with SMTP id 27so5043742wfd.4 for ; Wed, 06 Aug 2008 09:26:17 -0700 (PDT) Message-ID: Date: Wed, 6 Aug 2008 19:26:17 +0300 From: "Blue Swirl" Subject: Re: [Qemu-devel] Re: [PATCH 0/3]: Add UUID command-line option In-Reply-To: <48990DF6.90205@codemonkey.ws> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_23270_31154455.1218039977855" References: <488DC8B2.1070009@redhat.com> <20080728141515.GJ3196@minantech.com> <488DD98D.5010907@codemonkey.ws> <20080728153527.GA23771@minantech.com> <488F6E0E.2070504@codemonkey.ws> <20080729195048.GC11061@minantech.com> <20080805143319.GC3689@minantech.com> <48990DF6.90205@codemonkey.ws> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gleb Natapov ------=_Part_23270_31154455.1218039977855 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline On 8/6/08, Anthony Liguori wrote: > Gleb Natapov wrote: > > > > > > Here's a patch implementing a configuration ROM (probably in a bad > > > address) including a fake UUID. I skipped the more difficult parts > > > like kernel address etc. > > > > > > > > I haven't seen any comments on this. Anthony, is this approach > > acceptable? > > > > > > I like having a configuration blob but am uncomfortable with stashing it in > memory somewhere. I would think maybe stealing a few IO ports and using > that to read the rom may be nicer (albeit slower). I think it's something > that needs to be implemented fully to work out the kinks. Ok, I made a new version that uses IO ports. But then you have to select a port instead of address, is that any better? ------=_Part_23270_31154455.1218039977855 Content-Type: plain/text; name=pc_use_firmware_abi.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fjk5iu33 Content-Disposition: attachment; filename=pc_use_firmware_abi.diff SW5kZXg6IHFlbXUvaHcvcGMuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBxZW11Lm9yaWcvaHcvcGMuYwkyMDA4 LTA4LTA2IDE1OjMxOjU4LjAwMDAwMDAwMCArMDAwMAorKysgcWVtdS9ody9wYy5jCTIwMDgtMDgt MDYgMTY6MjI6NTIuMDAwMDAwMDAwICswMDAwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5jbHVkZSAi c21idXMuaCIKICNpbmNsdWRlICJib2FyZHMuaCIKICNpbmNsdWRlICJjb25zb2xlLmgiCisjaW5j bHVkZSAiZmlybXdhcmVfYWJpLmgiCiAKIC8qIG91dHB1dCBCb2NocyBiaW9zIGluZm8gbWVzc2Fn ZXMgKi8KIC8vI2RlZmluZSBERUJVR19CSU9TCkBAIC00MSw2ICs0Miw4IEBACiAjZGVmaW5lIFZH QUJJT1NfQ0lSUlVTX0ZJTEVOQU1FICJ2Z2FiaW9zLWNpcnJ1cy5iaW4iCiAKICNkZWZpbmUgUENf TUFYX0JJT1NfU0laRSAoNCAqIDEwMjQgKiAxMDI0KQorI2RlZmluZSBQQ19DRkdfUk9NX1BPUlQg MHgxMjM0CisjZGVmaW5lIFBDX0NGR19ST01fU0laRSA0MDk2CiAKIC8qIExlYXZlIGEgY2h1bmsg b2YgbWVtb3J5IGF0IHRoZSB0b3Agb2YgUkFNIGZvciB0aGUgQklPUyBBQ1BJIHRhYmxlcy4gICov CiAjZGVmaW5lIEFDUElfREFUQV9TSVpFICAgICAgIDB4MTAwMDAKQEAgLTcxMiw2ICs3MTUsODYg QEAKICAgICBuYl9uZTJrKys7CiB9CiAKK3R5cGVkZWYgc3RydWN0IENmZ1JPTVN0YXRlIHsKKyAg ICB1aW50OF90IGNmZ19yb21bUENfQ0ZHX1JPTV9TSVpFXTsKKyAgICB1aW50MTZfdCBjdXJyX2Fk ZHI7Cit9IENmZ1JPTVN0YXRlOworCitzdGF0aWMgaW50IHBjX2NmZ19yb21fc2V0X3BhcmFtcyhD ZmdST01TdGF0ZSAqcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNo YXIgKmFyY2gsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByYW1fYWRkcl90IGJl bG93XzRnX21lbV9zaXplLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmFtX2Fk ZHJfdCBhYm92ZV80Z19tZW1fc2l6ZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGNvbnN0IGNoYXIgKmJvb3RfZGV2aWNlcykKK3sKKyAgICB1aW50MzJfdCBzdGFydDsKKyAgICBv aHdjZmdfdjNfdCAqaGVhZGVyID0gKG9od2NmZ192M190ICopcy0+Y2ZnX3JvbTsKKyAgICBzdHJ1 Y3QgcGNfYXJjaF9jZmcgKnBjX2hlYWRlcjsKKyAgICBleHRlcm4gaW50IG5vZ3JhcGhpYzsKKwor ICAgIG1lbXNldChzLT5jZmdfcm9tLCAnXDAnLCBQQ19DRkdfUk9NX1NJWkUpOworCisgICAgLy8g VHJ5IHRvIG1hdGNoIFBQQyBOVlJBTQorICAgIHN0cmNweSgoY2hhciAqKWhlYWRlci0+c3RydWN0 X2lkZW50LCAiUUVNVV9CSU9TIik7CisgICAgaGVhZGVyLT5zdHJ1Y3RfdmVyc2lvbiA9IGNwdV90 b19sZTMyKDMpOyAvKiBzdHJ1Y3R1cmUgdjMgKi8KKworICAgIGhlYWRlci0+bnZyYW1fYXJjaF9w dHIgPSBjcHVfdG9fbGUxNihzaXplb2Yob2h3Y2ZnX3YzX3QpKTsKKyAgICBoZWFkZXItPm52cmFt X2FyY2hfc2l6ZSA9IGNwdV90b19sZTE2KHNpemVvZihzdHJ1Y3QgcGNfYXJjaF9jZmcpKTsKKyAg ICBzdHJjcHkoKGNoYXIgKiloZWFkZXItPmFyY2gsIGFyY2gpOworICAgIGhlYWRlci0+bmJfY3B1 cyA9IHNtcF9jcHVzICYgMHhmZjsKKyAgICBoZWFkZXItPlJBTTBfYmFzZSA9IDA7CisgICAgaGVh ZGVyLT5SQU0wX3NpemUgPSBjcHVfdG9fbGU2NCgodWludDY0X3QpYmVsb3dfNGdfbWVtX3NpemUp OworICAgIGlmIChhYm92ZV80Z19tZW1fc2l6ZSkgeworICAgICAgICBoZWFkZXItPlJBTTFfYmFz ZSA9IDB4MTAwMDAwMDAwVUxMOworICAgICAgICBoZWFkZXItPlJBTTFfc2l6ZSA9IGNwdV90b19s ZTY0KCh1aW50NjRfdClhYm92ZV80Z19tZW1fc2l6ZSk7CisgICAgfQorICAgIHN0cmNweSgoY2hh ciAqKWhlYWRlci0+Ym9vdF9kZXZpY2VzLCBib290X2RldmljZXMpOworICAgIGhlYWRlci0+bmJv b3RfZGV2aWNlcyA9IHN0cmxlbihib290X2RldmljZXMpICYgMHhmZjsKKworICAgIGlmIChub2dy YXBoaWMpCisgICAgICAgIGhlYWRlci0+Z3JhcGhpY19mbGFncyA9IGNwdV90b19sZTE2KE9IV19H Rl9OT0dSQVBISUNTKTsKKworICAgIHN0cm5jcHkoKGNoYXIgKiloZWFkZXItPnV1aWQsICJRRU1V UUVNVVFFTVVRRU1VIiwgMTYpOworCisgICAgaGVhZGVyLT5jcmMgPSBjcHVfdG9fbGUxNihPSFdf Y29tcHV0ZV9jcmMoaGVhZGVyLCAweDAwLCAweEY4KSk7CisKKyAgICAvLyBBcmNoaXRlY3R1cmUg c3BlY2lmaWMgaGVhZGVyCisgICAgc3RhcnQgPSBzaXplb2Yob2h3Y2ZnX3YzX3QpOworICAgIHBj X2hlYWRlciA9IChzdHJ1Y3QgcGNfYXJjaF9jZmcgKikmcy0+Y2ZnX3JvbVtzdGFydF07CisgICAg cGNfaGVhZGVyLT52YWxpZCA9IDE7CisKKyAgICByZXR1cm4gMDsKK30KKworc3RhdGljIHVpbnQz Ml90IHBjX2NmZ19yb21fcmVhZHcodm9pZCAqb3BhcXVlLCB1aW50MzJfdCBhZGRyKQoreworICAg IENmZ1JPTVN0YXRlICpzID0gKENmZ1JPTVN0YXRlICopb3BhcXVlOworCisgICAgaWYgKHMtPmN1 cnJfYWRkciA8IFBDX0NGR19ST01fU0laRSkKKyAgICAgICAgcmV0dXJuIHMtPmNmZ19yb21bcy0+ Y3Vycl9hZGRyXTsKKyAgICByZXR1cm4gMDsKK30KKworc3RhdGljIHZvaWQgcGNfY2ZnX3JvbV93 cml0ZXcodm9pZCAqb3BhcXVlLCB1aW50MzJfdCBhZGRyLCB1aW50MzJfdCB2YWx1ZSkKK3sKKyAg ICBDZmdST01TdGF0ZSAqcyA9IChDZmdST01TdGF0ZSAqKW9wYXF1ZTsKKworICAgIHMtPmN1cnJf YWRkciA9IHZhbHVlOworfQorCitzdGF0aWMgdm9pZCAqcGNfY2ZnX3JvbV9tYXAodWludDMyX3Qg YWRkcikKK3sKKyAgICBDZmdST01TdGF0ZSAqczsKKworICAgIHMgPSBxZW11X21hbGxvY3ooc2l6 ZW9mKENmZ1JPTVN0YXRlKSk7CisgICAgaWYgKCFzKQorICAgICAgICByZXR1cm4gTlVMTDsKKwor ICAgIHJlZ2lzdGVyX2lvcG9ydF9yZWFkKGFkZHIsIDIsIDIsIHBjX2NmZ19yb21fcmVhZHcsIHMp OworICAgIHJlZ2lzdGVyX2lvcG9ydF93cml0ZShhZGRyLCAyLCAyLCBwY19jZmdfcm9tX3dyaXRl dywgcyk7CisKKyAgICByZXR1cm4gczsKK30KKwogLyogUEMgaGFyZHdhcmUgaW5pdGlhbGlzYXRp b24gKi8KIHN0YXRpYyB2b2lkIHBjX2luaXQxKHJhbV9hZGRyX3QgcmFtX3NpemUsIGludCB2Z2Ff cmFtX3NpemUsCiAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpib290X2RldmljZSwg RGlzcGxheVN0YXRlICpkcywKQEAgLTg2Nyw2ICs5NTAsMTYgQEAKICAgICBjcHVfcmVnaXN0ZXJf cGh5c2ljYWxfbWVtb3J5KCh1aW50MzJfdCkoLWJpb3Nfc2l6ZSksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBiaW9zX3NpemUsIGJpb3Nfb2Zmc2V0IHwgSU9fTUVNX1JPTSk7CiAK KyAgICB7CisgICAgICAgIENmZ1JPTVN0YXRlICpjZmdfcm9tOworCisgICAgICAgIC8qIG1hcCBj b25maWd1cmF0aW9uIFJPTSAqLworICAgICAgICBjZmdfcm9tID0gcGNfY2ZnX3JvbV9tYXAoUENf Q0ZHX1JPTV9QT1JUKTsKKyAgICAgICAgcGNfY2ZnX3JvbV9zZXRfcGFyYW1zKGNmZ19yb20sIHBj aV9lbmFibGVkPyAicGMiIDogImlzYXBjIiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGJlbG93XzRnX21lbV9zaXplLCBhYm92ZV80Z19tZW1fc2l6ZSwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGJvb3RfZGV2aWNlKTsKKyAgICB9CisKICAgICBib2Noc19iaW9zX2luaXQo KTsKIAogICAgIGlmIChsaW51eF9ib290KQpJbmRleDogcWVtdS9ody9maXJtd2FyZV9hYmkuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBxZW11Lm9yaWcvaHcvZmlybXdhcmVfYWJpLmgJMjAwOC0wOC0wNiAxNToz MTo1OC4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvaHcvZmlybXdhcmVfYWJpLmgJMjAwOC0wOC0w NiAxNTozMjoyNy4wMDAwMDAwMDAgKzAwMDAKQEAgLTU0LDggKzU0LDEwIEBACiAgICAgdWludDhf dCAgcGFkM1s1XTsKICAgICAvKiAweEQwOiBib290IGRldmljZXMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKi8KICAgICB1aW50OF90ICBib290X2RldmljZXNbMHgxMF07Ci0gICAgLyogMHhF MCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICovCi0gICAgdWludDhf dCAgcGFkNFsweDFDXTsgLyogMjggKi8KKyAgICAvKiAweEUwOiBVVUlEICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKi8KKyAgICB1aW50OF90ICB1dWlkWzB4MTBdOworICAgIC8q IDB4RjAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAqLworICAgIHVp bnQ4X3QgIHBhZDRbMHhDXTsgLyogMTIgKi8KICAgICAvKiAweEZDOiBjaGVja3N1bSAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKi8KICAgICB1aW50MTZfdCBjcmM7CiAgICAgdWludDhf dCAgcGFkNVsweDAyXTsKQEAgLTE3Niw2ICsxNzgsMTIgQEAKICAgICBoZWFkZXItPmNoZWNrc3Vt ID0gdG1wOwogfQogCisvKiBQQyBjb25maWd1cmF0aW9uIHN0cnVjdHVyZSAqLworc3RydWN0IHBj X2FyY2hfY2ZnIHsKKyAgICB1aW50OF90IHZhbGlkOworICAgIHVpbnQ4X3QgdW51c2VkWzYzXTsK K307CisKICNlbHNlIC8qIF9fQVNTRU1CTFlfXyAqLwogCiAvKiBTdHJ1Y3R1cmUgb2Zmc2V0cyBm b3IgYXNtIHVzZSAqLwpJbmRleDogcWVtdS9ody9zdW40bS5jCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHFlbXUu b3JpZy9ody9zdW40bS5jCTIwMDgtMDgtMDYgMTU6MzE6NTguMDAwMDAwMDAwICswMDAwCisrKyBx ZW11L2h3L3N1bjRtLmMJMjAwOC0wOC0wNiAxNTozMjoyNy4wMDAwMDAwMDAgKzAwMDAKQEAgLTIx Myw2ICsyMTMsOCBAQAogICAgIGlmIChub2dyYXBoaWMpCiAgICAgICAgIGhlYWRlci0+Z3JhcGhp Y19mbGFncyA9IGNwdV90b19iZTE2KE9IV19HRl9OT0dSQVBISUNTKTsKIAorICAgIHN0cm5jcHko KGNoYXIgKiloZWFkZXItPnV1aWQsICJRRU1VUUVNVVFFTVVRRU1VIiwgMTYpOworCiAgICAgaGVh ZGVyLT5jcmMgPSBjcHVfdG9fYmUxNihPSFdfY29tcHV0ZV9jcmMoaGVhZGVyLCAweDAwLCAweEY4 KSk7CiAKICAgICAvLyBBcmNoaXRlY3R1cmUgc3BlY2lmaWMgaGVhZGVyCkluZGV4OiBxZW11L2h3 L3N1bjR1LmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gcWVtdS5vcmlnL2h3L3N1bjR1LmMJMjAwOC0wOC0wNiAx NTozMTo1OC4wMDAwMDAwMDAgKzAwMDAKKysrIHFlbXUvaHcvc3VuNHUuYwkyMDA4LTA4LTA2IDE1 OjMyOjI3LjAwMDAwMDAwMCArMDAwMApAQCAtMTQ0LDYgKzE0NCw4IEBACiAgICAgaWYgKG5vZ3Jh cGhpYykKICAgICAgICAgaGVhZGVyLT5ncmFwaGljX2ZsYWdzID0gY3B1X3RvX2JlMTYoT0hXX0dG X05PR1JBUEhJQ1MpOwogCisgICAgc3RybmNweSgoY2hhciAqKWhlYWRlci0+dXVpZCwgIlFFTVVR RU1VUUVNVVFFTVUiLCAxNik7CisKICAgICBoZWFkZXItPmNyYyA9IGNwdV90b19iZTE2KE9IV19j b21wdXRlX2NyYyhoZWFkZXIsIDB4MDAsIDB4RjgpKTsKIAogICAgIC8vIEFyY2hpdGVjdHVyZSBz cGVjaWZpYyBoZWFkZXIK ------=_Part_23270_31154455.1218039977855--