[Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes

["Blue Swirl" <blauwirbel@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Hi,

I made a series of patches that add -Wstrict-prototypes to the CFLAGS
and then -Wmissing-prototypes, both of which are enabled by Xen. I
also fixed most warnings generated -Wstrict-prototypes and some of
them for the -Wmissing-prototypes case.

Compiling with -Wstrict-prototypes produces only one extra warning. I
think this flag should be enabled.

But dyngen targets spew a lot of noise with -Wmissing-prototypes so
I'm not proposing to add that (or maybe that should be coupled with
CONFIG_DYNGEN_OP). This also meant that I did not care enough to fix
all warnings. The current warning fix should be safe to apply anyway.

Comments?

[-- Attachment #2: wstrict_prototypes.diff --]
[-- Type: plain/text, Size: 1007 bytes --]

[-- Attachment #3: fix_wstrict_prototypes_warnings.diff --]
[-- Type: plain/text, Size: 2876 bytes --]

[-- Attachment #4: wmissing_prototypes.diff --]
[-- Type: plain/text, Size: 1089 bytes --]

[-- Attachment #5: fix_wmissing_prototypes_warnings.diff --]
[-- Type: plain/text, Size: 15100 bytes --]