From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KScWq-0005iy-1x for qemu-devel@nongnu.org; Mon, 11 Aug 2008 14:54:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KScWo-0005gt-2j for qemu-devel@nongnu.org; Mon, 11 Aug 2008 14:54:03 -0400 Received: from [199.232.76.173] (port=52763 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KScWn-0005ge-RB for qemu-devel@nongnu.org; Mon, 11 Aug 2008 14:54:01 -0400 Received: from yx-out-1718.google.com ([74.125.44.156]:39422) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KScWn-0001Us-IR for qemu-devel@nongnu.org; Mon, 11 Aug 2008 14:54:01 -0400 Received: by yx-out-1718.google.com with SMTP id 3so777500yxi.82 for ; Mon, 11 Aug 2008 11:54:00 -0700 (PDT) Message-ID: Date: Mon, 11 Aug 2008 21:53:59 +0300 From: "Blue Swirl" Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH 0/7] merge some xen bits into qemu In-Reply-To: <48A034B9.3010906@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080805150328.GT4478@implementation.uk.xensource.com> <20080806140132.GL4448@implementation.uk.xensource.com> <4899B06F.2090101@redhat.com> <20080806142526.GN4448@implementation.uk.xensource.com> <20080806221047.GE4486@implementation> <489AA532.7040006@redhat.com> <489B1316.1030109@redhat.com> <48A034B9.3010906@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: xen-devel@lists.xensource.com, Ian Jackson , Markus Armbruster , qemu-devel@nongnu.org, Samuel Thibault On 8/11/08, Gerd Hoffmann wrote: > Blue Swirl wrote: > > I extracted a small patch that only introduces the nodisk_ok part. > > Anybody unhappy if I commit it? > > > How about converting all struct fields to C99 initializers in > hw/sun4*.c? Mixing the two styles looks quite odd. Good idea, I'll do the switch.