From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KU5YM-0004PS-O3
	for qemu-devel@nongnu.org; Fri, 15 Aug 2008 16:05:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KU5YM-0004Ou-5I
	for qemu-devel@nongnu.org; Fri, 15 Aug 2008 16:05:42 -0400
Received: from [199.232.76.173] (port=46674 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KU5YL-0004Op-Su
	for qemu-devel@nongnu.org; Fri, 15 Aug 2008 16:05:41 -0400
Received: from yx-out-1718.google.com ([74.125.44.156]:3231)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KU5YL-0005zS-Hd
	for qemu-devel@nongnu.org; Fri, 15 Aug 2008 16:05:41 -0400
Received: by yx-out-1718.google.com with SMTP id 3so716468yxi.82
	for <qemu-devel@nongnu.org>; Fri, 15 Aug 2008 13:05:40 -0700 (PDT)
Message-ID: <f43fc5580808151305j7079e945n2f919f8f8409901a@mail.gmail.com>
Date: Fri, 15 Aug 2008 23:05:40 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [RFC, PATCH] Host AIO support detection,
	OpenBSD host support
In-Reply-To: <Pine.LNX.4.64.0808140148090.2344@linmac.oyster.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <f43fc5580808121145u483ef7b8l6cb86165d259cf93@mail.gmail.com>
	<48A1E8AD.9040501@codemonkey.ws>
	<f43fc5580808130948s37a3cee7s6c0e00ee3c24d3b9@mail.gmail.com>
	<Pine.LNX.4.64.0808140148090.2344@linmac.oyster.ru>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 8/14/08, malc <av1474@comtv.ru> wrote:
> On Wed, 13 Aug 2008, Blue Swirl wrote:
>
>
> > On 8/12/08, Anthony Liguori <anthony@codemonkey.ws> wrote:
> >
> > > Blue Swirl wrote:
> > >
> > >
> > > > Here are two patches, loosely based on patches in OpenBSD ports system
> > > > that enable compiling Qemu. The first patch makes AIO use conditional
> > > > on host AIO support. The second one adjusts various include files etc.
> > > >
> > > > I'd like to commit both of these, is that OK?
> > > >
> > > >
> > > >
> > >
> > >  The first patch is fine but the second patch has some bogus things in
> it.
> > >
> >
> > Thanks for the review. I removed the unneeded parts, made a separate
> > patch for fixing OSS selection, and added a configure option for AIO
> > as requested by Samuel Thibault.
> >
>
>  Thanks for the OSS bits, i have committed slightly modified patch that
>  takes all possible drivers into consideration.

Great, but there is a bug in your commit, *) case seems to be checked
before oss|sdl... case gets into play so the error is still present:

Error: Unknown driver 'oss' selected
Possible drivers are: oss sdl esd