qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Blue Swirl" <blauwirbel@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] Fix OpenBSD linker warnings
Date: Sun, 17 Aug 2008 23:19:28 +0300	[thread overview]
Message-ID: <f43fc5580808171319t3ac57471o36877c535a585e5a@mail.gmail.com> (raw)
In-Reply-To: <f43fc5580808151320v6a0c40b2o2491f85d11196b35@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On 8/15/08, Blue Swirl <blauwirbel@gmail.com> wrote:
> OpenBSD gcc issues warnings for some suspicious constructs, like:
>  slirp/tcp_subr.c:1077: warning: Array size (256) smaller than format
>  string size (257) (arg 3)
>  vl.o(.text+0x7bc0): In function `drive_init':
>  vl.c:5464: warning: strcpy() is almost always misused, please use strlcpy()
>
>  This patch silences the warnings. Comments?

Updated patch with more fixes attached.

It's easy to make mistakes with these kind of changes, so review and
comments are welcome.

[-- Attachment #2: fix_obsd_ld_warnings.diff --]
[-- Type: plain/text, Size: 35867 bytes --]

  reply	other threads:[~2008-08-17 20:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 20:20 [Qemu-devel] [PATCH] Fix OpenBSD linker warnings Blue Swirl
2008-08-17 20:19 ` Blue Swirl [this message]
2008-08-18 14:09 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f43fc5580808171319t3ac57471o36877c535a585e5a@mail.gmail.com \
    --to=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).