[Qemu-devel] [PATCH] Fix OpenBSD linker warnings

[Qemu-devel] [PATCH] Fix OpenBSD linker warnings

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

OpenBSD gcc issues warnings for some suspicious constructs, like:
slirp/tcp_subr.c:1077: warning: Array size (256) smaller than format
string size (257) (arg 3)
vl.o(.text+0x7bc0): In function `drive_init':
vl.c:5464: warning: strcpy() is almost always misused, please use strlcpy()

This patch silences the warnings. Comments?

[-- Attachment #2: fix_obsd_ld_warnings.diff --]
[-- Type: plain/text, Size: 23669 bytes --]

[Qemu-devel] Re: [PATCH] Fix OpenBSD linker warnings

[Blue Swirl]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On 8/15/08, Blue Swirl <blauwirbel@gmail.com> wrote:
> OpenBSD gcc issues warnings for some suspicious constructs, like:
>  slirp/tcp_subr.c:1077: warning: Array size (256) smaller than format
>  string size (257) (arg 3)
>  vl.o(.text+0x7bc0): In function `drive_init':
>  vl.c:5464: warning: strcpy() is almost always misused, please use strlcpy()
>
>  This patch silences the warnings. Comments?

Updated patch with more fixes attached.

It's easy to make mistakes with these kind of changes, so review and
comments are welcome.

[-- Attachment #2: fix_obsd_ld_warnings.diff --]
[-- Type: plain/text, Size: 35867 bytes --]

Re: [Qemu-devel] [PATCH] Fix OpenBSD linker warnings

[Anthony Liguori]

Blue Swirl wrote:
> OpenBSD gcc issues warnings for some suspicious constructs, like:
> slirp/tcp_subr.c:1077: warning: Array size (256) smaller than format
> string size (257) (arg 3)
> vl.o(.text+0x7bc0): In function `drive_init':
> vl.c:5464: warning: strcpy() is almost always misused, please use strlcpy()
>
> This patch silences the warnings. Comments?
>   

Definitely a good thing.  strcpy()/sprintf() should never be used IMHO.

Regards,

Anthony Liguori