From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXJji-0001Fn-Vc
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 13:50:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXJjg-0001Cm-CE
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 13:50:45 -0400
Received: from [199.232.76.173] (port=53187 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXJjf-0001C3-Pi
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 13:50:43 -0400
Received: from wf-out-1314.google.com ([209.85.200.170]:53861)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KXJjf-0008Nd-II
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 13:50:43 -0400
Received: by wf-out-1314.google.com with SMTP id 27so1547866wfd.4
	for <qemu-devel@nongnu.org>; Sun, 24 Aug 2008 10:50:42 -0700 (PDT)
Message-ID: <f43fc5580808241050k13245aafsc4cb60930208ff4@mail.gmail.com>
Date: Sun, 24 Aug 2008 20:50:42 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available.
In-Reply-To: <20080824113319.5652.30494.stgit@gleb-debian.qumranet.com.qumranet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080824113258.5652.92531.stgit@gleb-debian.qumranet.com.qumranet.com>
	<20080824113319.5652.30494.stgit@gleb-debian.qumranet.com.qumranet.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 8/24/08, Gleb Natapov <gleb@qumranet.com> wrote:
>  +# uuid library
>  +if test "$uuid" = "yes" ; then
>  +  `pkg-config uuid 2> /dev/null` || uuid="no"
>  +fi

Please implement the probe like ncurses one.

>  +static int uuid_dont_generate;

Positive logic would be clearer: generate_uuid = 1;

>  +#ifdef CONFIG_UUID
>  +                uuid_dont_generate = 1;

generate_uuid = 0;

>  +    if (!uuid_dont_generate)
>  +        uuid_generate(qemu_uuid);

if (generate_uuid)