From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KY22h-0000q2-LA
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 13:09:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KY22f-0000oS-9l
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 13:09:18 -0400
Received: from [199.232.76.173] (port=48324 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KY22e-0000oI-Uy
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 13:09:17 -0400
Received: from wf-out-1314.google.com ([209.85.200.175]:14604)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KY22e-0005Xw-B6
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 13:09:16 -0400
Received: by wf-out-1314.google.com with SMTP id 27so2387936wfd.4
	for <qemu-devel@nongnu.org>; Tue, 26 Aug 2008 10:09:15 -0700 (PDT)
Message-ID: <f43fc5580808261009o4464c4acq9930f46c47797a96@mail.gmail.com>
Date: Tue, 26 Aug 2008 20:09:15 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [5087] Fix more bugs in r5044
In-Reply-To: <b2fa41d60808251410y103d5267nb51ece89ba1743e0@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1KXiuX-0008MV-Nr@cvs.savannah.gnu.org>
	<b2fa41d60808251410y103d5267nb51ece89ba1743e0@mail.gmail.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 8/26/08, Igor Kovalenko <igor.v.kovalenko@gmail.com> wrote:
> On Tue, Aug 26, 2008 at 12:43 AM, Blue Swirl <blauwirbel@gmail.com> wrote:
>  > Revision: 5087
>  >          http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5087
>  > Author:   blueswir1
>  > Date:     2008-08-25 20:43:37 +0000 (Mon, 25 Aug 2008)
>  >
>  > Log Message:
>  > -----------
>  > Fix more bugs in r5044
>  >
>  > Modified Paths:
>  > --------------
>  >    trunk/audio/audio.c
>  >    trunk/i386-dis.c
>  >
>
> > Modified: trunk/i386-dis.c
>  > ===================================================================
>  > --- trunk/i386-dis.c    2008-08-25 20:03:28 UTC (rev 5086)
>  > +++ trunk/i386-dis.c    2008-08-25 20:43:37 UTC (rev 5087)
>  > @@ -2826,7 +2826,7 @@
>  >  oappend (s)
>  >      const char *s;
>  >  {
>  > -  pstrcpy (obufp, (size_t)(obufp - obuf), s);
>  > +  pstrcpy (obufp, sizeof(obuf) - (size_t)(obufp - obuf), s);
>  >   obufp += strlen (s);
>  >  }
>  >
>  >
>
>
> Now the disassembler output is truncated; you need to revert this part
>  of change to i386-dis.c
>  The problem is that obufp is not always a pointer into obuf data, see
>  i386-dis.c:2497      obufp = op1out;

Thanks. I didn't have a plan how to fix this properly, so I reverted it.