From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KYlqw-0001aa-VR
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 14:04:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KYlqw-0001Z5-FD
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 14:04:14 -0400
Received: from [199.232.76.173] (port=34523 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KYlqw-0001Yn-Ar
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 14:04:14 -0400
Received: from yx-out-1718.google.com ([74.125.44.152]:40905)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <blauwirbel@gmail.com>) id 1KYlqu-0002pJ-Tz
	for qemu-devel@nongnu.org; Thu, 28 Aug 2008 14:04:13 -0400
Received: by yx-out-1718.google.com with SMTP id 3so250232yxi.82
	for <qemu-devel@nongnu.org>; Thu, 28 Aug 2008 11:04:12 -0700 (PDT)
Message-ID: <f43fc5580808281104l565e9554sce3ce760d4f47c58@mail.gmail.com>
Date: Thu, 28 Aug 2008 21:04:11 +0300
From: "Blue Swirl" <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/6] Use IO port for qemu<->guest BIOS
	communication.
In-Reply-To: <20080828165237.22851.1532.stgit@gleb-debian.qumranet.com.qumranet.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080828165232.22851.77678.stgit@gleb-debian.qumranet.com.qumranet.com>
	<20080828165237.22851.1532.stgit@gleb-debian.qumranet.com.qumranet.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 8/28/08, Gleb Natapov <gleb@qumranet.com> wrote:
>  +    fw_cfg_add(fw_cfg, FW_CFG_ID, (uint8_t *)&bios_cfg_id,
>  +               sizeof(bios_cfg_id));

On second thought, this is in host byte order, which is not a good idea.